Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] ALL_PROXY is undocumented #5558

Closed
jiasli opened this issue Aug 17, 2020 · 1 comment · Fixed by #5978
Closed

[Doc] ALL_PROXY is undocumented #5558

jiasli opened this issue Aug 17, 2020 · 1 comment · Fixed by #5978
Labels
Documentation PR(s) Wanted

Comments

@jiasli
Copy link

jiasli commented Aug 17, 2020

Expected Result

The doc for Proxies should include ALL_PROXY introduced by #3185 and its precedence compared to HTTP_PROXY and HTTPS_PROXY.

Actual Result

The document Proxies lacks the description for ALL_PROXY, and the only appearance of ALL_PROXY is in the Release History.
@jiasli jiasli mentioned this issue Aug 17, 2020
Closed
@nateprewitt
Copy link
Member

If anyone would like to provide a PR for this, we'd be fine reviewing it.

@sha016 sha016 mentioned this issue Nov 14, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation PR(s) Wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mention all_proxy env variable in Proxies section sha016/requests
3 participants
@jiasli @nateprewitt and others