Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow computation of GRID_ESP via qcschema #2307

Closed
lilyminium opened this issue Sep 28, 2021 · 5 comments · Fixed by #3095
Closed

Allow computation of GRID_ESP via qcschema #2307

lilyminium opened this issue Sep 28, 2021 · 5 comments · Fixed by #3095
Labels
api Involves the Psi4 API. How do users access "stuff"? blocked For issues that are blocked until some other development happens. external-interface For issues about interfaces with external programs: ADCC, CheMPS2, GDMA, MRCC...
Milestone

Comments

@lilyminium
Copy link

Hi Psi4 developers,

The QCSchema method of input to Psi4 is super convenient and plays well with standard I/O packagers like QCEngine, but it only allows the computation of a limited number of properties:

can_do_properties_ = {
"dipole", "quadrupole", "mulliken_charges", "lowdin_charges", "wiberg_lowdin_indices", "mayer_indices"
}

It would be really convenient to compute other oeprops as well, especially GRID_ESP, using the schema framework. Would it be possible / desirable to have this in Psi4?

Example use

model = qcelemental.models.AtomicInput(
    molecule=mol,
    driver="properties",
    model={"method": "SCF", "basis": "sto-3g", properties=["GRID_ESP", "GRID_FIELD"]},
    keywords={"scf_type": "df",
              "grid": my_mol_grid}
)

result = qcengine.compute(model, "psi4")

assert result.properties.grid_esp is not None
@loriab
Copy link
Member

loriab commented Sep 28, 2021

It's grid_field.dat and grid_esp.dat files that you're after?

Apart from that can_do_properties list you linked, a barrier has been that there isn't a place to stash gridded properties in QCSchema. Most of the other properties are stored in scalar or array qcvariables. Alfter MolSSI/QCElemental#275 is in place, we'll be able to return those, though it still won't be proper QCSchema.

@lilyminium
Copy link
Author

It's grid_field.dat and grid_esp.dat files that you're after?

Yes, pretty much.

Apart from that can_do_properties list you linked, a barrier has been that there isn't a place to stash gridded properties in QCSchema. Most of the other properties are stored in scalar or array qcvariables. Alfter MolSSI/QCElemental#275 is in place, we'll be able to return those, though it still won't be proper QCSchema.

Thanks for the explanation, I'm not very familiar with either Psi4 or the MolSSI QC stack. That PR is to return the actual files, right? As a user I would immediately read them into arrays; would those arrays be able to be stored as qcvariables?

@loriab
Copy link
Member

loriab commented Sep 28, 2021

you'd submit to psi4 with input.protocols.native_files = "all" and then access the file contents as result.native_files["grid_field.dat"], and that can be readily read into arrays. we don't have any grid-dependent qcvariables at present. adding those would probably need a pass that included MO cube files.

@JonathonMisiewicz JonathonMisiewicz added api Involves the Psi4 API. How do users access "stuff"? blocked For issues that are blocked until some other development happens. external-interface For issues about interfaces with external programs: ADCC, CheMPS2, GDMA, MRCC... labels Oct 1, 2021
@loriab
Copy link
Member

loriab commented Nov 1, 2023

There's a stopgap fix for this here MolSSI/QCEngine#434

@lilyminium
Copy link
Author

Oh fantastic -- thanks @loriab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Involves the Psi4 API. How do users access "stuff"? blocked For issues that are blocked until some other development happens. external-interface For issues about interfaces with external programs: ADCC, CheMPS2, GDMA, MRCC...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants