Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1 roadmap #41

Closed
psolom opened this issue Aug 31, 2016 · 5 comments
Closed

Release 1.1 roadmap #41

psolom opened this issue Aug 31, 2016 · 5 comments
Milestone

Comments

@psolom
Copy link
Owner

psolom commented Aug 31, 2016

I'm going to update this list with requested feature for 1.1 later.

Here the list of thing which is done and available at dev branch:

@psolom
Copy link
Owner Author

psolom commented Sep 11, 2016

Things done at the "dev" branch:

@psolom
Copy link
Owner Author

psolom commented Sep 11, 2016

Backward incompatible changes:

@psolom psolom mentioned this issue Sep 11, 2016
@fabriceci
Copy link
Contributor

fabriceci commented Sep 18, 2016

Wow! You made a lot a work, awesome! I will soon have a little time, I'm going to look at the code's modifications.

I have 3 suggestions before to release this version:

  1. Complete separation : config

There are now duplicate parameters (examples : "security", "exclude", "upload", etc.) in client/server configuration.

This is confusing and not necessary, the only correct one is the server config. During the plugin initialization, the plugin should retrieve the correct configuration through the connector.

  1. Complete separation : repository

Ideal situation : I use a package manager like Bower to handle my JavaScript files and another one for my server connector.

  • I don't want to download all connectors each time I update the plugin.
  • The server code should be separate to be available in a package manager like Composer/Gradle.
  • I don't know want to download a new version of the plugin where there nothing to me, just bug fixes in connectors I don't use.

The client and server should have a different lifetime now. 1 repository for the plugin , and 1 per connector.

  1. JSON Standardization

We discuss about that. We should reach a point where the JavaScript plugin can evolve without break connectors (in view of the lot of work you did, maybe after this version).

We should keep in mind that there are a lot a chance that many maintainers will update very tardily (or never) their connectors.

If you intent to standardize the API, you should do this now because I think this is the last big modification in the API. Doing this after involve asking again to the maintainers to update their connectors.

What do you think?

Again great work!

@psolom
Copy link
Owner Author

psolom commented Sep 19, 2016

Hi @fabriceci, thanks for appreciating my work.
With regards to your suggestions:

  1. Yeah, I also like the idea to move duplicate parameters to one place. If you remember I described the "init" method for this purpose (here and here) and I even have implemented the "init"method few commits ago, but removed it later.

The first problem here is that connector's maintainer should care that his configuration for "security" or "upload" options are compatible with client-side code. For example, maintainer would like to use regex in "uploadRestrictions" in the connector, but he can't because the backward compatible will be broken.

The second problem is that not all client-side parameters of the sections are used at the backend. Let's consider "images" and "upload" sections. As you can see the connector doesn't use images.showThumbs and upload.multiple parameters and they are not exist in server-side config, since they are client-side related only.

In light of the above I have decided to remove the "init" method yet, because I don't have a solution at the moment. Feel free to share your ideas in #32 if you have any. I will gladly revert the "init" method back once I have a solution.

  1. Good idea, I'm gonna add this point to my todo list, but the implementation will be postponed since there are other things with the higher priority in the list.

  2. I have already stated the work on JSON API implementation. It will take some time and will bring severe changes in the code. I'm gonna release it in 1-2 weeks.

Thanks for your ideas, I appreciate your contribution.

@psolom
Copy link
Owner Author

psolom commented Nov 4, 2016

I am pleased to present a new major release of RichFilemanager v.2.0.0 (instead of v.1.1 due to a lot of major and incompatible changes)

Release notes:

@psolom psolom added this to the 2.0.0 milestone Nov 12, 2016
@psolom psolom closed this as completed Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants