Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about patching our xcb-proto with x11rb-specific changes #369

Open
eduardosm opened this issue Apr 24, 2020 · 1 comment
Open

Think about patching our xcb-proto with x11rb-specific changes #369

eduardosm opened this issue Apr 24, 2020 · 1 comment
Labels
P5 Priority Nice-to-have

Comments

@eduardosm
Copy link
Collaborator

There are some issues that could be fixed by modifying the XML definitions. For example #156 could be fixed by adding name= attributes and #357 could be fixed by fixing and uncommenting the broken definitions. Additionally, some unions could be converted into switches to make the API more rust-y.

However, many of those modifications cannot be merged upstream because they would likely break libxcb. So, it might be a good idea to think about a way of patching our copy of xcb-proto with x11rb-specific changes.

@psychon
Copy link
Owner

psychon commented Apr 24, 2020

For now, I'd prefer to merge changes upstream. In theory, I have commits right there, but in practice, I never really touched xcb-proto and only did some things on libxcb. Thus, I would not really want to "just merge" something there.

Anyway, the name= you propose for #156 could just be added there. Uncommenting the broken definitions for #357 could be merged upstream together with an extra patch to libxcb that makes it ignore the new stuff in there.

I am not really sure about converting unions to switches. For xproto's ClientMessageData... oh, that's actually possible. Same for the <union> in randr. Hm, nice idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P5 Priority Nice-to-have
Projects
None yet
Development

No branches or pull requests

2 participants