Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests(service): self-contained tests #172

Open
SHAcollision opened this issue Oct 19, 2024 · 0 comments · May be fixed by #249
Open

Tests(service): self-contained tests #172

SHAcollision opened this issue Oct 19, 2024 · 0 comments · May be fixed by #249
Assignees

Comments

@SHAcollision
Copy link
Collaborator

Currently, all tests for the service need cargo run running on another terminal.

We could turn our axum server into a mod we can import and run on the tests themselves within a once cell. This is of course not so easy because tokyo kills it when the first test finishes, but there is probably a solution.

This would both:

  • make it easier to run the test suite locally as only cargo test is needed
  • make it faster to run the test suite in the GH workflows as we skip the cargo run build.
@SHAcollision SHAcollision changed the title Self-contiained tests Chore: self-contiained tests Nov 18, 2024
@SHAcollision SHAcollision changed the title Chore: self-contiained tests Tests(service): self-contained tests Nov 19, 2024
@amirRamirfatahi amirRamirfatahi self-assigned this Dec 10, 2024
@amirRamirfatahi amirRamirfatahi linked a pull request Dec 12, 2024 that will close this issue
2 tasks
@SHAcollision SHAcollision linked a pull request Dec 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants