-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Country information in models #68
Comments
What do you mean by that? Can you elaborate? |
Sure, I mean if I provide API for travelling between different countries it can be useful to know in what country some station/stop/location is. {
"description": "Bus Station (Dworzec PKS) on 1 Sucha str.",
"id": 598,
"keywords": "Wroclaw Wroclaw Wroclaw Вроцлав",
"location": {
"latitude": "51.096756",
"longitude": "17.035747"
},
"state": "PL",
"title": "Wroclaw"
} And that would be good to have optional property in Does that answer your question? |
In public-transport/transport-apis#1, we had a similar discussion: How do we define a mechanism to encode a geographical/political relationship that works across the globe? We agreed that using ISO-3166 is the best system we're currently aware of. Regarding your proposal (adding a field named What do you think @juliuste, @matkoniecz & @kiliankoe? |
https://github.com/osmlab/name-suggestion-index may be useful here They record where given brand is active - most of that is country level but sometimes special weirdness needs to be handled. See say https://github.com/osmlab/name-suggestion-index/blob/37b1ecead8a22d9833fd48eea9977d5207a69716/data/brands/amenity/fast_food.json#L512 that (a) excludes
See osmlab/name-suggestion-index#4817 In general that project has this part of setting in quite active use, so this solution is relatively battle tested (it was redesigned at least once) See https://github.com/osmlab/name-suggestion-index/wiki/Contributing#locationset-required for documentation |
But usually trips happen from one political entity to another one, isn't it? |
|
Let's follow |
Hi,
Have you thought about adding country info to specification?
The text was updated successfully, but these errors were encountered: