Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Input Field After Selecting a Module/Step #1825

Open
vivek-30 opened this issue Feb 26, 2021 · 10 comments
Open

Clear Input Field After Selecting a Module/Step #1825

vivek-30 opened this issue Feb 26, 2021 · 10 comments
Labels

Comments

@vivek-30
Copy link

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

The Step remains Intact in the input field Even after its selection.

observe it here -

Screen.Recording.2021-02-26.at.10.29.04.PM.mov

What did you expect to see that you didn't?

After Selecting a Step/Module the input field must be Cleared out, so that a user don't have to manually erase it to choose another step.

Please show us where to look

https://beta.sequencer.publiclab.org/

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@vivek-30 vivek-30 added the bug label Feb 26, 2021
@welcome
Copy link

welcome bot commented Feb 26, 2021

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!
Don't forget to join our PublicLab Gitter channel and our ImageSequencer Gitter Channel for some brainstorming discussions.

@vivek-30
Copy link
Author

@harshkhandeparkar what do you think of this ?

@harshkhandeparkar
Copy link
Member

A small but nice change.

@KarishmaVanwari
Copy link

@harshkhandeparkar can I work on this?

@harshkhandeparkar
Copy link
Member

@harshkhandeparkar can I work on this?

Go ahead!

@k99sharma
Copy link

Hi, I would like to fix this issue. Do you still want this fixed?

@harshkhandeparkar
Copy link
Member

Hi, I would like to fix this issue. Do you still want this fixed?

Sure!

@k99sharma
Copy link

Hey, I tried looking for the bug. I found this in the index.html file in examples/ folder.
index.html

index html - image-sequencer - Gitpod Code

I looked in the demo.js file which is calling addStepsUI handler function to add options in here. We are seeing the last choosed option because we added <options> in <select> manually using the script.

This handler is present in this file defaultHTMLSequencerUi. But I am not able to figure out how is this file getting generated.

@harshkhandeparkar
Copy link
Member

It's not a generated file, it is the source.

@harshkhandeparkar
Copy link
Member

You can run npm start to test your changes in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants