Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in webglColormapGenerator.js file #313

Open
Somya-Singhal opened this issue Apr 3, 2022 · 4 comments
Open

Issues in webglColormapGenerator.js file #313

Somya-Singhal opened this issue Apr 3, 2022 · 4 comments

Comments

@Somya-Singhal
Copy link
Contributor

pl-6

I found there are some bugs in this file like fn function is declared inside if statement but used outside it also and some issues with opening and closing of paranthesis.
@Somya-Singhal
Copy link
Contributor Author

Hello @TildaDares , Can I work on this issue to improve the code?

@jywarren
Copy link
Member

jywarren commented Apr 5, 2022

Hi @Somya-Singhal sure, if you'd like to open a PR that would be great! Thank you!

@Somya-Singhal
Copy link
Contributor Author

Sure, I will do it shortly.

@Somya-Singhal Somya-Singhal mentioned this issue Apr 6, 2022
Open
@Somya-Singhal
Copy link
Contributor Author

Hello @jywarren , I linked a pull request. Can you please review it and suggest the changes if any needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jywarren @Somya-Singhal