Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: this should never happen #1

Open
clehner opened this issue Dec 27, 2015 · 3 comments
Open

Error: this should never happen #1

clehner opened this issue Dec 27, 2015 · 3 comments

Comments

@clehner
Copy link
Member

clehner commented Dec 27, 2015

This occurred when I resumed patchwork with SIGCONT after having stopped it with SIGSTOP for a few hours.

Uncaught Exception:
Error: this should never happen
    at /usr/local/src/patchwork/node_modules/pull-many/index.js:91:37
    at next (/usr/local/src/patchwork/node_modules/pull-many/index.js:107:9)
    at read (/usr/local/src/patchwork/node_modules/pull-many/index.js:114:40)
    at /usr/local/src/patchwork/node_modules/scuttlebot/node_modules/pull-stream/throughs.js:101:14
    at start (/usr/local/src/patchwork/node_modules/pull-paramap/index.js:36:7)
    at drain (/usr/local/src/patchwork/node_modules/pull-paramap/index.js:23:21)
    at /usr/local/src/patchwork/node_modules/pull-paramap/index.js:47:13
    at Object.cb (/usr/local/src/patchwork/node_modules/secure-scuttlebutt/index.js:307:11)
    at /usr/local/src/patchwork/node_modules/ssb-feed/util.js:47:12
    at Array.forEach (native)
@dominictarr
Copy link
Member

I guess that might happen if current.read threw because then https://github.com/dominictarr/pull-many/blob/master/index.js#L106 would not get set and then https://github.com/dominictarr/pull-many/blob/master/index.js#L104 would be activated, although it was actually async.

@dominictarr
Copy link
Member

if it threw, and then something caught the error and kept on running (as patchwork does!)

@clehner
Copy link
Member Author

clehner commented Dec 28, 2015

Yes, patchwork kept running when that happened. It hasn't happened again since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants