Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit the test folder or remove the prepublish script #5

Open
DDunc opened this issue Apr 12, 2017 · 3 comments
Open

Commit the test folder or remove the prepublish script #5

DDunc opened this issue Apr 12, 2017 · 3 comments

Comments

@DDunc
Copy link

DDunc commented Apr 12, 2017

...because right now npm install throws an error from the prepublish script running the test script. It doesn't impact anything but might be intimidating to learners or irk the easily annoyed. It would also probably be a good idea to explain that the intended usage is for people to run pull.js and duplex.js with node from the command line.

The content is well done and appropriate for the beginner level, so substituting out the non-technical phrase 'start with' for repeatable instructions could make these examples more accessible. Great work!

@dominictarr
Copy link
Member

goddamn, npm was meant to fix that thing, like a year ago.

@dominictarr
Copy link
Member

yeah, I'll remove prepublish

@dominictarr
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants