Add structured repo docs #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
add-structured-repo-docs
branch
11 times, most recently
from
b8352cf
to
44a6dbe
Compare
hstct
reviewed
Jul 20, 2022
hstct
reviewed
Jul 20, 2022
daviddavis
force-pushed
the
add-structured-repo-docs
branch
from
44a6dbe
to
6e61366
Compare
quba42
requested changes
Jul 20, 2022
There was a problem hiding this comment.
Since a full rework of the existing docs won't happen any time soon, and this PR brings an obvious benefit (docs for a workflow that was previously undocumented), I am not too worried about making the style perfectly consistent with the existing docs.
Since @hstct says he tried out the workflow and it worked, I say we merge. Perhaps after my nitpick with the change note is resolved 😄.
Thanks a ton @daviddavis for providing these docs, and @hstct for the initial review!
[noissue]
daviddavis
force-pushed
the
add-structured-repo-docs
branch
from
6e61366
to
ae2a4af
Compare
hstct
approved these changes
Jul 20, 2022
quba42
approved these changes
Jul 21, 2022
Backport to 2.19: 💚 backport PR created✅ Backport PR branch: Backported as #593 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script in the docs will be tested by the CI:
pulp_deb/.github/workflows/scripts/script.sh
Line 20 in 0429ddd
pulp_deb/.github/workflows/scripts/script.sh
Lines 41 to 43 in 0429ddd