Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure repomd.xml file is never cached by cache proxies #2947

Closed
Tracked by #2533
praiskup opened this issue Feb 4, 2023 · 3 comments · Fixed by #3193
Closed
Tracked by #2533

Make sure repomd.xml file is never cached by cache proxies #2947

praiskup opened this issue Feb 4, 2023 · 3 comments · Fixed by #3193
Assignees
@ggainey
Labels
COPR Features desired by the COPR Team Feature prio-list

Comments

@praiskup
Copy link

praiskup commented Feb 4, 2023

For example AWS CloudFront can be used to geographically cache-proxy the traffic
to a PULP instance.

RPMs can be cached, but also RPM metadata files, except for repomd.xml file.
That needs to always provide the latest-greatest version, because it refers to
the actual/fresh metadata files that the consumers are interested into.

Copr sets the Cache-Control=no-cache header to avoid CloudFront caching.

We need PULP to automatically set this header, too.

Additional context

This issue is a part of the future Copr <-> PULP integration efforts.
@praiskup praiskup mentioned this issue Feb 8, 2023
Open
31 tasks
@dralley dralley added COPR Features desired by the COPR Team prio-list and removed Triage-Needed labels Feb 10, 2023
@pulpbot pulpbot moved this to Free to take in RH Pulp Kanban board Feb 10, 2023
@Conan-Kudo
Copy link

Same goes for repomd.xml.asc (repo digest) and repomd.xml.key (repo public key)

@dralley
Copy link
Contributor

dralley commented Feb 10, 2023

Yup

@ggainey ggainey self-assigned this May 30, 2023
@pulpbot pulpbot moved this from Free to take to In Progress in RH Pulp Kanban board May 30, 2023
ggainey added a commit to ggainey/pulpcore that referenced this issue May 31, 2023
@ggainey
Extensions to give plugins a chance to set specific content-headers.
fd899ac 
Added Distribution.content_headers_for() and call it from inside
Handler.response_headers().

This is in support of pulp/pulp_rpm#2947

[noissue]
This was referenced May 31, 2023
Merged
Closed
ggainey added a commit to ggainey/pulpcore that referenced this issue Jun 2, 2023
@ggainey
Extensions to give plugins a chance to set specific content-headers.
2706428 
Added Distribution.content_headers_for() and call it from inside
Handler.response_headers().

This is in support of pulp/pulp_rpm#2947

closes pulp#3897.
ggainey added a commit to ggainey/pulpcore that referenced this issue Jun 5, 2023
@ggainey
Extensions to give plugins a chance to set specific content-headers.
a18d5b8 
Added Distribution.content_headers_for() and call it from inside
Handler.response_headers().

This is in support of pulp/pulp_rpm#2947

closes pulp#3897.
ggainey added a commit to ggainey/pulpcore that referenced this issue Jun 8, 2023
@ggainey
Extensions to give plugins a chance to set specific content-headers.
4221e71 
Added Distribution.content_headers_for() and call it from inside
Handler.response_headers().

This is in support of pulp/pulp_rpm#2947

closes pulp#3897.
ggainey added a commit to ggainey/pulpcore that referenced this issue Jun 12, 2023
@ggainey
Extensions to give plugins a chance to set specific content-headers.
d49bb43 
Added Distribution.content_headers_for() and call it from inside
Handler.response_headers().

This is in support of pulp/pulp_rpm#2947

closes pulp#3897.
ipanova pushed a commit to pulp/pulpcore that referenced this issue Jun 13, 2023
@ggainey @ipanova
Extensions to give plugins a chance to set specific content-headers.
186cb38 
Added Distribution.content_headers_for() and call it from inside
Handler.response_headers().

This is in support of pulp/pulp_rpm#2947

closes #3897.
ggainey added a commit to ggainey/pulp_rpm that referenced this issue Jul 11, 2023
@ggainey
Take advantage of Dist.content_headers_for() to no-cache repomd and f…
fa2b1b9 
…riends.

Requires pulpcore support release in core/3.28.

fixes pulp#2947.
ggainey added a commit to ggainey/pulp_rpm that referenced this issue Jul 11, 2023
@ggainey
Take advantage of Dist.content_headers_for() to no-cache repomd and f…
980305a 
…riends.

Requires pulpcore support release in core/3.28.

fixes pulp#2947.
@ggainey ggainey mentioned this issue Jul 11, 2023
Merged
@pulpbot pulpbot moved this from In Progress to Needs review in RH Pulp Kanban board Jul 11, 2023
@ggainey
Copy link
Contributor

ggainey commented Aug 3, 2023

To work on object-storage backends requires this fix as well : pulp/pulpcore#4251

dralley pushed a commit that referenced this issue Aug 16, 2023
@ggainey @dralley
Take advantage of Dist.content_headers_for() to no-cache repomd and f…
6b999b4 
…riends.

Requires pulpcore support release in core/3.28.

fixes #2947.
@pulpbot pulpbot moved this from Needs review to Done in RH Pulp Kanban board Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggainey ggainey

Labels
COPR Features desired by the COPR Team Feature prio-list
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take advantage of Dist.content_headers_for() to no-cache repomd and f… ggainey/pulp_rpm
4 participants
@Conan-Kudo @dralley @praiskup @ggainey