Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String integers in modulemd version are no longer accepted #2998

Closed
Alex-Welsh opened this issue Mar 7, 2023 · 7 comments
Closed

String integers in modulemd version are no longer accepted #2998

Alex-Welsh opened this issue Mar 7, 2023 · 7 comments
Labels
Issue Triage-Needed

Comments

@Alex-Welsh
Copy link
Contributor

Version
Pulpcore 3.21.5
Pulp RPM 3.19.0

Describe the bug
Since the removal of libmodulemd, the version field strictly requires an integer. Previously, strings that represented integers were accepted without issue.

To Reproduce
Rocky 9.1 appstream - rockylinux.anexia.at/9.1/AppStream/x86_64/os/repodata/02fa9664-23dd-4215-bf82-c9c3bfb2c54d-MODULES.yaml.gz has this issue. Attempting to sync the data will result in something like: Provided modular data is invalid:'["'9010020221119202858' is not of type 'integer'"]'

Expected behavior
No error. Sync completes

Additional context
Rocky 9.1 and 8.7 can be compared to see the change that has caused this issue. See:

curl -fsSL rockylinux.anexia.at/9.1/AppStream/x86_64/os/repodata/02fa9664-23dd-4215-bf82-c9c3bfb2c54d-MODULES.yaml.gz | gzip -d | grep version

and

curl -fsSL rockylinux.anexia.at/8.7/AppStream/x86_64/os/repodata/01fa634a16e45ab9aa2894048a90689edf293648226e7c0783dc926b16e796b9-modules.yaml.gz | gzip -d | grep version:| head
@Alex-Welsh Alex-Welsh mentioned this issue Mar 7, 2023
Merged
@dralley
Copy link
Contributor

dralley commented Mar 7, 2023

Well, let's start by filing an upstream issue with RockyLinux to let them know they ought to comply with the schema :)

I'm not generally against merging this as a stopgap but if they can fix it quickly then everyone wins.

@Alex-Welsh
Copy link
Contributor Author

I made a matching upstream bug report here

Alex-Welsh added a commit to stackhpc/pulp_rpm that referenced this issue Mar 9, 2023
@Alex-Welsh
Allow string integers in modulemd version
e2205c2 
Trivial fix, allows modulemd version data to be of type string if that
string represents a valid integer, matching very basic regex.
closes pulp#2998
@oyvindkolbu
Copy link

Any hope in getting this merged? Since the update to pulp_rpm 3.19 we've been unable to sync Rocky 9 repos.

@dralley
Copy link
Contributor

dralley commented Mar 15, 2023

I suppose so, no responses yet...

Alex-Welsh added a commit to stackhpc/pulp_rpm that referenced this issue Mar 15, 2023
@Alex-Welsh
Allow string integers in modulemd version
29762aa 
Trivial fix, allows modulemd version data to be of type string if that
string represents a valid integer, matching very basic regex.
closes pulp#2998
Alex-Welsh added a commit to stackhpc/pulp_rpm that referenced this issue Mar 15, 2023
@Alex-Welsh
Allow string integers in modulemd version
61a2560 
Trivial fix, allows modulemd version data to be of type string if that
string represents a valid integer, matching very basic regex.
closes pulp#2998
Alex-Welsh added a commit to stackhpc/pulp_rpm that referenced this issue Mar 15, 2023
@Alex-Welsh
Allow string integers in modulemd version
45734bc 
Trivial fix, allows modulemd version data to be of type string if that
string represents a valid integer, matching very basic regex.
closes pulp#2998
@pulpbot pulpbot moved this to Done in RH Pulp Kanban board Mar 15, 2023
patchback bot pushed a commit that referenced this issue Mar 15, 2023
@Alex-Welsh @patchback
Allow string integers in modulemd version
114b55e 
Trivial fix, allows modulemd version data to be of type string if that
string represents a valid integer, matching very basic regex.
closes #2998

(cherry picked from commit 45d1e14)
dralley pushed a commit that referenced this issue Mar 15, 2023
@Alex-Welsh @dralley
Allow string integers in modulemd version
846e80b 
Trivial fix, allows modulemd version data to be of type string if that
string represents a valid integer, matching very basic regex.
closes #2998

(cherry picked from commit 45d1e14)
@oyvindkolbu
Copy link

Thank you for fixing it. Can you also release a new 3.19?

@dralley
Copy link
Contributor

dralley commented Mar 20, 2023

Yes, it should happen today

@katamadone
Copy link

thank you for fixing it.. worked for us.

@dralley dralley mentioned this issue May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dralley @oyvindkolbu @katamadone @Alex-Welsh