Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.repo should not contain an invalid repo id #3170

Closed
sdherr opened this issue Jun 13, 2023 · 0 comments · Fixed by #3171
Closed

config.repo should not contain an invalid repo id #3170

sdherr opened this issue Jun 13, 2023 · 0 comments · Fixed by #3171
Labels
Issue Triage-Needed

Comments

@sdherr
Copy link
Contributor

sdherr commented Jun 13, 2023 •
edited
Loading

The repo ID in the [] in a .repo file can only contain alphanumeric characters plus -_.:. pulp_rpm currently writes the Distribution's name there, which can be any string. pulp_rpm should not generate invalid repo files if the distro name is unusual.
sdherr added a commit to sdherr/pulp_rpm that referenced this issue Jun 13, 2023
@sdherr
Don't write invalid characters to a repo id, even if the distro name
2c18a2e 
contains them.

closes pulp#3170
@dralley dralley mentioned this issue Jun 13, 2023
Closed
@sdherr sdherr mentioned this issue Jun 13, 2023
Merged
dralley pushed a commit that referenced this issue Jun 13, 2023
@sdherr @dralley
Don't write invalid characters to a repo id, even if the distro name
b13fb89 
contains them.

closes #3170
patchback bot pushed a commit that referenced this issue Jun 13, 2023
@sdherr @patchback
Don't write invalid characters to a repo id, even if the distro name
04084ca 
contains them.

closes #3170

(cherry picked from commit b13fb89)
@patchback patchback bot mentioned this issue Jun 13, 2023
Merged
@pulpbot pulpbot moved this to Done in RH Pulp Kanban board Jun 13, 2023
dralley pushed a commit that referenced this issue Jun 13, 2023
@sdherr @dralley
Don't write invalid characters to a repo id, even if the distro name
17b9c47 
contains them.

closes #3170

(cherry picked from commit b13fb89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't write invalid characters to a repo id, even if the distro name contains them. sdherr/pulp_rpm
1 participant
@sdherr