[PR #2851/52a9accc backport][3.17] Fixed concurrent-ks-tree-syncs by making disttree ID repo-specific. #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
DistributionTree digest and subrepo-names now both end with the pulp-id of the "owning" Repository, making them unique to that repo and therefore protected from concurrent-updates against anything that is changing that Repository. Addon/Variant/Image are transitively made unique by virtue of having their DistributionTree be part of their unique-together. Sub-repo **content** (e.g. Packages et al) are de-duplicated via their existing uniqueness constraints. The end result is a minor increase in Content objects (i.e., DistTrees/Addons/Images/Variants that used to have only one instance are now one-per-containing-repo), and a small impact on subrepo-syncing (since previously-unique subrepos will now have a first-sync that would have been skipped). Content will continue to only be sync'd once. fixes #2278. [nocoverage] (cherry picked from commit 52a9acc)
|
The failures here are due to the DistributionTree-naming-fix colliding with the use of limited-width CharFields (instead of TextFields) in 3.17. We currently don't have an active request to release a 3.17.z with this fix, so I'm going to close this PR. Note that if we do decide to fix 3.17, we could wrap the naming-trick we're doing here in an extra sha256() to get a result that will fit into the more-narrowly-defined field. |
dralley
deleted the
patchback/backports/3.17/52a9accc79e49991a8941622b60485e1845d23a2/pr-2851
branch
|
Being backported in #3154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2851 as merged into main (52a9acc).
DistributionTree digest and subrepo-names now both end with the pulp-id of the "owning" Repository, making them unique to that repo and therefore protected from concurrent-updates against anything that is changing that Repository.
Addon/Variant/Image are transitively made unique by virtue of having their DistributionTree be part of their unique-together.
Sub-repo content (e.g. Packages et al) are de-duplicated via their existing uniqueness constraints.
The end result is a minor increase in Content objects (i.e., DistTrees/Addons/Images/Variants that used to have only one instance are now one-per-containing-repo), and a small impact on subrepo-syncing (since previously-unique subrepos will now have a first-sync that would have been skipped). Content will continue to only be sync'd once.
fixes #2278.
fixes #2775.
closes #2304.
[nocoverage]