Fixed performance-tests. #3096
Merged
Fixed performance-tests. #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved fixtures shared between 'functional' and 'performance' up one level. Fixed some problems w/ the tests themselves as well. fixes pulp#3095
lubosmj
approved these changes
Apr 4, 2023
dralley
approved these changes
Apr 4, 2023
gerrod3
approved these changes
Apr 4, 2023
I thought about that, but was swayed by commentary from Somewhere On The Net around "performance is better when you keep fixtures as 'close to' the tests that use them as possible". I could easily just move the entire functional/conftest.py up to test/conftest.py. Should I do that here? In a fresh PR? Or, just leave it be? |
|
Let it be. Let's merge this PR. I need this PR for resolving merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved fixtures shared between 'functional' and 'performance' up one level.
Fixed some problems w/ the tests themselves as well.
fixes #3095