Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected PulpImport/Export handling of sub-content. #2193

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Corrected PulpImport/Export handling of sub-content. #2193

merged 1 commit into from
Feb 10, 2022

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Feb 2, 2022

fixes #2192.
[nocoverage]

dralley
dralley approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, caveat that I have limited background with import/export

mdellweg
mdellweg approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of refactored the PR in my head to understand. So please feel free to ignore my comments.

CHANGES/2192.bugfix Show resolved Hide resolved
pulpcore/app/modelresource.py Show resolved Hide resolved
pulpcore/app/modelresource.py Outdated Show resolved Hide resolved
pulpcore/app/modelresource.py Outdated Show resolved Hide resolved
pulpcore/app/modelresource.py Outdated Show resolved Hide resolved
@mdellweg
Copy link
Member

CI Failure is intermittent and unrelated. Can we merge anyway?

@ggainey
Copy link
Contributor Author

ggainey commented Feb 10, 2022

CI Failure is intermittent and unrelated. Can we merge anyway?

I can't - but if someone else has button-access, I'm good w/ pushing it.

@dkliban dkliban merged commit 849d410 into pulp:main Feb 10, 2022
@patchback
Copy link

patchback bot commented Feb 16, 2022 •
edited
Loading

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/849d4103f513f1f5faecbacb684f2e918af2e5e2/pr-2193

Backported as #2231

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Feb 16, 2022 •
edited
Loading

Backport to 3.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.16/849d4103f513f1f5faecbacb684f2e918af2e5e2/pr-2193

Backported as #2234

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Feb 16, 2022 •
edited
Loading

Backport to 3.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.17/849d4103f513f1f5faecbacb684f2e918af2e5e2/pr-2193

Backported as #2233

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Feb 16, 2022 •
edited
Loading

Backport to 3.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.15/849d4103f513f1f5faecbacb684f2e918af2e5e2/pr-2193

Backported as #2232

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

This was referenced Feb 16, 2022
Merged
Merged
Merged
Merged
@ggainey ggainey deleted the 2192_pie_kstree branch May 10, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

@dralley dralley dralley approved these changes

@dkliban dkliban dkliban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PulpImport/Export of kickstart repos with subrepos broken
4 participants
@ggainey @mdellweg @dkliban @dralley