Updated Merge of #25 Against Master #33
Conversation
Range selection mimics Hipmunk. Also streamlines button creation.
support for deselecting dates and ensure calendarView:shouldSelectDate: is respected when selecting date ranges
Was only scrolling to the month of the given date. Also added secondary method to allow customizing the scroll position.
…ke into account self.pinsHeaderToTop Also added date range selection demo to test app
Added public properties for text shadow color, today's text color, today's shadow color. Also added public property to toggle display of dates that fall outside of the current month.
The copy headers build phase wasn't making the headers available to the parent project (and breaking the ability to Archive the parent project). Moving headers to copy files build phase resolved the problem. Not sure this is the correct fix ...
… feature/date-range-selection Conflicts: TimesSquare/TSQCalendarRowCell.m
…Date` are updated appropriately when the selection type changes
|
Additional cleanups layered on top of #25 |
| @property (nonatomic, strong) UIButton *todayButton; | ||
| @property (nonatomic, strong) UIButton *selectedButton; | ||
| { | ||
| NSUInteger buttonStates[7]; |
There was a problem hiding this comment.
Shouldn't hardcode 7 here. There's a daysInWeek property.
There was a problem hiding this comment.
Also: this shouldn't be NSUInteger, it should be an enum of some sort.
|
@blakewatters & @mattgrayson this is a awesome PR. 👍 from me for merging (once @puls`s amendments are in - do you guys need support for this?). |
|
@blakewatters perhaps we should re-test this PR on a real device. I just checked the performance on an iPad2 (iOS7) and the scrolling performance dropped a lot. |
|
I fixed a serious memory / performance issue earlier today on the TAFlights This patch needs some more love IMO before merge. I just need to find On Monday, September 23, 2013, Sebastian Roth wrote:
To stay sane & productive, I don't live in e-mail. If you need to reach me |
|
Just heads up for anyone interested in this work: I have elected to cut bait on TimesSquare and implement a new calendar based on collection views (PSTCollectionView or UICollectionView). I will not be picking this effort back up. |
No description provided.