🐛 fix(formatting): add more stricter ruleser

Signed-off-by: Pauline <git@ethanlibs.co>

package.json

@@ -4,7 +4,7 @@
 	"type": "module",
 	"version": "4.4.1",
 	"private": true,
-	"packageManager": "pnpm@9.13.2",
+	"packageManager": "pnpm@9.14.1",
 	"engineStrict": true,
 	"author": "@flowr",
 	"contributors": [
@@ -50,10 +50,6 @@
 	"devDependencies": {
 		"@arethetypeswrong/cli": "^0.17.0",
 		"@flowr/eslint": "workspace:^",
-		"@microsoft/api-extractor": "^7.47.11",
-		"@microsoft/api-extractor-model": "^7.29.8",
-		"@microsoft/tsdoc": "^0.15.0",
-		"@microsoft/tsdoc-config": "^0.17.0",
 		"@turbo/gen": "^2.3.0",
 		"@types/jsdom": "^21.1.7",
 		"@types/node": "^22.9.0",

packages/eslint-plugin/src/rules/consistent-list-newline.ts

@@ -137,6 +137,7 @@ export default createEslintRule<Options, MessageIds>({
 			const endLoc = context.sourceCode.getLocFromIndex(endRange);
 
 			const lastItem = items[items.length - 1];
+			// eslint-disable-next-line ts/no-unnecessary-condition -- side effects
 			if (mode === 'newline' && endLoc.line === lastLine) {
 				context.report({
 					data: {
@@ -149,6 +150,7 @@ export default createEslintRule<Options, MessageIds>({
 					node: lastItem,
 				});
 			}
+			// eslint-disable-next-line ts/no-unnecessary-condition -- side effects
 			else if (mode === 'inline' && endLoc.line !== lastLine) {
 				// if there is only one multiline item, we allow the closing bracket to be on the a different line
 				if (items.length === 1 && items[0].loc.start.line !== items[1]?.loc.start.line)
@@ -274,4 +276,5 @@ export default createEslintRule<Options, MessageIds>({
 	name: RULE_NAME,
 });
 
+// eslint-disable-next-line ts/no-unnecessary-type-parameters -- type testing
 function exportType<A, _B extends A>(): void { }

packages/eslint-plugin/src/rules/file-header.ts

@@ -190,8 +190,8 @@ function makeComment(text: string, syntax: CommentSyntax, decor: DecorSyntax): s
 
 function matchHeader(src: string, headers: string[], templates: TemplatesSyntax): boolean {
 	for (const header of headers) {
-		const body = escapeRegex(header)
-			.replace(/\\\{(\w+)\\\}/g, (m, k) => templates[k]?.[0] ?? m);
+		// eslint-disable-next-line ts/no-unnecessary-condition -- weak types
+		const body = escapeRegex(header).replace(/\\\{(\w+)\\\}/g, (m, k) => templates[k]?.[0] ?? m);
 		if (new RegExp(`^${body}$`).test(src))
 			return true;
 	}
@@ -200,6 +200,7 @@ function matchHeader(src: string, headers: string[], templates: TemplatesSyntax)
 }
 
 function makeHeader(headers: string[], templates: TemplatesSyntax): string {
+	// eslint-disable-next-line ts/no-unnecessary-condition -- weak types
 	return headers[0].replace(/\{(\w+)\}/g, (m, k) => templates[k]?.[1] ?? m);
 }
 

packages/eslint-plugin/src/rules/if-newline.ts

@@ -7,8 +7,6 @@ export type Options = [];
 export default createEslintRule<Options, MessageIds>({
 	create: context => ({
 		IfStatement: (node) => {
-			if (!node.consequent)
-				return;
 			if (node.consequent.type === 'BlockStatement')
 				return;
 			if (node.test.loc.end.line === node.consequent.loc.start.line)

packages/eslint-plugin/src/rules/indent-unindent.ts

@@ -13,13 +13,13 @@ const defaultOptions: Options = [{
 
 export default createEslintRule<Options, MessageIds>({
 	create: (context) => {
-		const { tags = ['$', 'unindent', 'unIndent'] } = context.options[0] ?? {};
+		const { tags = ['$', 'unindent', 'unIndent'] } = context.options[0];
 		const tagSet = new Set(tags);
 
 		return {
 			TaggedTemplateExpression: (node) => {
 				const id = node.tag;
-				if (!id || id.type !== 'Identifier')
+				if (id.type !== 'Identifier')
 					return;
 				if (!tagSet.has(id.name))
 					return;

packages/eslint-plugin/src/rules/no-discard-result.ts

@@ -87,7 +87,7 @@ function hasResultLikeReturnType(
 	const returnType = unwrapPotentialPromise(checker, nodeMap);
 	const resultType = getResultType(service, checker);
 
-	if (!returnType || !returnType.aliasSymbol || !resultType?.aliasSymbol)
+	if (!returnType.aliasSymbol || !resultType?.aliasSymbol)
 		return false;
 
 	// hacky bit of reflection logic until type relationship api https://github.com/microsoft/TypeScript/issues/9879

packages/eslint-plugin/src/rules/no-only-tests.ts

@@ -13,9 +13,9 @@ export type Options = [{
 function getCallPath(node: TSESTree.Node, path: string[] = []): string[] {
 	if (node.type === 'Identifier')
 		return [node.name, ...path];
-	if (node.type === 'MemberExpression' && node.object)
+	if (node.type === 'MemberExpression')
 		return getCallPath(node.object, [(node.property as TSESTree.Identifier).name, ...path]);
-	if (node.type === 'CallExpression' && node.callee)
+	if (node.type === 'CallExpression')
 		return getCallPath(node.callee, path);
 
 	return path;

packages/eslint-plugin/src/rules/top-level-function.ts

@@ -21,13 +21,13 @@ export default createEslintRule<Options, MessageIds>({
 
 			if (declaration.init?.type !== 'ArrowFunctionExpression')
 				return;
-			if (declaration.id?.type !== 'Identifier')
+			if (declaration.id.type !== 'Identifier')
 				return;
 			if (declaration.id.typeAnnotation)
 				return;
 			if (
 				declaration.init.body.type !== 'BlockStatement'
-				&& declaration.id?.loc.start.line === declaration.init?.body.loc.end.line
+				&& declaration.id.loc.start.line === declaration.init.body.loc.end.line
 			)
 				return;
 

packages/eslint/package.json

@@ -150,7 +150,7 @@
 		"@eslint-community/eslint-plugin-eslint-comments": "^4.4.1",
 		"@eslint/compat": "^1.2.3",
 		"@eslint/markdown": "^6.2.1",
-		"@stylistic/eslint-plugin": "^2.10.1",
+		"@stylistic/eslint-plugin": "^2.11.0",
 		"@typescript-eslint/eslint-plugin": "^8.15.0",
 		"@typescript-eslint/parser": "^8.15.0",
 		"@vitest/eslint-plugin": "^1.1.10",
@@ -162,17 +162,17 @@
 		"eslint-plugin-jsdoc": "^50.5.0",
 		"eslint-plugin-jsonc": "^2.18.2",
 		"eslint-plugin-n": "^17.13.2",
-		"eslint-plugin-perfectionist": "^3.9.1",
+		"eslint-plugin-perfectionist": "^4.0.1",
 		"eslint-plugin-petal": "workspace:^",
 		"eslint-plugin-regexp": "^2.7.0",
 		"eslint-plugin-toml": "^0.11.1",
-		"eslint-plugin-unicorn": "^56.0.0",
+		"eslint-plugin-unicorn": "^56.0.1",
 		"eslint-plugin-unused-imports": "^4.1.4",
 		"eslint-plugin-yml": "^1.15.0",
 		"find-up-simple": "^1.0.0",
 		"globals": "^15.12.0",
 		"jsonc-eslint-parser": "^2.4.0",
-		"local-pkg": "^0.5.0",
+		"local-pkg": "^0.5.1",
 		"toml-eslint-parser": "^0.10.0",
 		"yaml-eslint-parser": "^1.2.3"
 	},

packages/eslint/scripts/typegen.ts

@@ -1,6 +1,6 @@
 import { writeFile } from 'node:fs/promises';
-import { builtinRules } from 'eslint/use-at-your-own-risk';
 import { flatConfigsToRulesDTS } from 'eslint-typegen/core';
+import { builtinRules } from 'eslint/use-at-your-own-risk';
 import {
 	astro,
 	comments,

packages/eslint/src/configs/gitignore.ts

@@ -38,31 +38,31 @@ function relativeMinimatch(pattern: string, relativePath: string, cwd: string):
 	if (new Set(['', '.', '/']).has(relativePath))
 		return pattern;
 
-	const negated = pattern.startsWith('!') ? '!' : ':';
-	const minimatch = { clearPattern: negated ? pattern.slice(1) : pattern };
+	const negated = pattern.startsWith('!') ? '!' : '';
+	const minimatch = { cleanPattern: negated ? pattern.slice(1) : pattern };
 
 	if (!relativePath.endsWith('/'))
 		relativePath = `${relativePath}/`;
 
 	const parent = relativePath.startsWith('..');
 
 	if (!parent)
-		return `${negated}${relativePath}${minimatch.clearPattern}`;
+		return `${negated}${relativePath}${minimatch.cleanPattern}`;
 
 	if (!relativePath.match(/^(?:\.\.\/)+$/))
 		throw new Error('the ignored file location should be a parent or child directory.');
 
-	if (minimatch.clearPattern.startsWith('**'))
+	if (minimatch.cleanPattern.startsWith('**'))
 		return pattern;
 
 	const parents = relative(resolve(cwd, relativePath), cwd).split(/[/\\]/);
-	while (parents.length && minimatch.clearPattern.startsWith(`${parents[0]}/`)) {
-		minimatch.clearPattern = minimatch.clearPattern.slice(parents[0].length + 1);
+	while (parents.length && minimatch.cleanPattern.startsWith(`${parents[0]}/`)) {
+		minimatch.cleanPattern = minimatch.cleanPattern.slice(parents[0].length + 1);
 		parents.shift();
 	}
 
-	if (minimatch.clearPattern.startsWith('**') || parents.length === 0)
-		return `${negated}${minimatch.clearPattern}`;
+	if (minimatch.cleanPattern.startsWith('**') || parents.length === 0)
+		return `${negated}${minimatch.cleanPattern}`;
 
 	return null;
 }

packages/eslint/src/configs/perfectionist.ts

@@ -1,29 +1,31 @@
 import type { TypedFlatConfigItem } from '../types/index.ts';
 import { interopDefault } from '../utils.ts';
 
-type SortConfig = ['error', {
+interface SortConfig {
 	type?: ('alphabetical' | 'natural' | 'line-length');
 	order?: ('asc' | 'desc');
-}];
+
+}
+
+const sortConfig: SortConfig = { order: 'asc', type: 'natural' };
 
 /**
  * Perfectionist plugin for props and items sorting.
  *
  * @see https://github.com/azat-io/eslint-plugin-perfectionist
  */
 export async function perfectionist(): Promise<TypedFlatConfigItem[]> {
-	const sortConfig: SortConfig = ['error', { order: 'asc', type: 'natural' }];
-
 	return [
 		{
 			name: 'petal/perfectionist/setup',
 			plugins: {
 				perfectionist: await interopDefault(import('eslint-plugin-perfectionist')),
 			},
 			rules: {
-				'perfectionist/sort-array-includes': sortConfig,
-				'perfectionist/sort-exports': sortConfig,
+				'perfectionist/sort-array-includes': ['error', sortConfig],
+				'perfectionist/sort-exports': ['error', sortConfig],
 				'perfectionist/sort-imports': ['error', {
+					...sortConfig,
 					groups: [
 						'type',
 						['parent-type', 'sibling-type', 'index-type'],
@@ -37,12 +39,10 @@ export async function perfectionist(): Promise<TypedFlatConfigItem[]> {
 						'unknown',
 					],
 					newlinesBetween: 'ignore',
-					order: 'asc',
-					type: 'natural',
 				}],
-				'perfectionist/sort-named-exports': sortConfig,
-				'perfectionist/sort-named-imports': sortConfig,
-				'perfectionist/sort-sets': sortConfig,
+				'perfectionist/sort-named-exports': ['error', sortConfig],
+				'perfectionist/sort-named-imports': ['error', sortConfig],
+				'perfectionist/sort-sets': ['error', sortConfig],
 			},
 		},
 	];

packages/eslint/src/configs/typescript.ts

@@ -78,6 +78,7 @@ export async function typescript(options: OptionsTypeScript = {}): Promise<Typed
 					'ts-ignore': false,
 					'ts-nocheck': false,
 				}],
+				'ts/no-unnecessary-parameter-property-assignment': 'error',
 				'ts/ban-tslint-comment': 'error',
 				'ts/class-literal-property-style': ['error', 'fields'],
 				'ts/class-methods-use-this': ['error', { ignoreClassesThatImplementAnInterface: true, ignoreOverrideMethods: false }],
@@ -111,6 +112,7 @@ export async function typescript(options: OptionsTypeScript = {}): Promise<Typed
 					allowTernary: true,
 				}],
 				'ts/no-unused-vars': 'off',
+				'ts/no-useless-empty-export': 'error',
 				'ts/no-use-before-define': ['error', { classes: false, functions: false, variables: true }],
 				'ts/no-useless-constructor': 'off',
 				'ts/no-wrapper-object-types': 'error',
@@ -165,8 +167,14 @@ export async function typescript(options: OptionsTypeScript = {}): Promise<Typed
 					'ts/no-unsafe-argument': 'error',
 					'ts/no-unsafe-assignment': 'error',
 					'ts/no-unsafe-call': 'error',
+					'ts/no-unnecessary-type-parameters': 'error',
 					'ts/no-unsafe-member-access': 'error',
+					'ts/no-unnecessary-type-arguments': 'error',
+					'ts/no-unnecessary-template-expression': 'error',
+					'ts/no-unnecessary-qualifier': 'error',
+					'ts/no-unnecessary-condition': ['error', { allowConstantLoopConditions: true }],
 					'ts/no-unsafe-return': 'error',
+					'ts/no-unnecessary-boolean-literal-compare': 'error',
 					'ts/related-getter-setter-pairs': 'error',
 					'ts/prefer-readonly': 'off',
 					'ts/promise-function-async': 'error',

packages/eslint/src/utils.ts

@@ -181,7 +181,7 @@ export const isPackageInScope = (name: string): boolean => isPackageExists(name,
  * ```
  */
 export async function ensurePackages(packages: Array<string | undefined>): Promise<void> {
-	if (process.env.CI || process.stdout.isTTY === false || isCwdInScope === false)
+	if (process.env.CI || !process.stdout.isTTY || !isCwdInScope)
 		return;
 
 	const nonExistingPackages = packages.filter(i => i && !isPackageInScope(i)) as string[];
@@ -201,6 +201,7 @@ export function resolveSubOptions<Key extends keyof OptionsConfig>(options: Opti
 	return typeof options[key] === 'boolean' ? {} as any : options[key] || {};
 }
 
+// eslint-disable-next-line ts/no-unnecessary-type-parameters -- weird types
 export function getOverrides<Key extends keyof OptionsConfig>(options: OptionsConfig, key: Key): Partial<Linter.RulesRecord & Rules> {
 	const sub = resolveSubOptions(options, key);
 	return { ...'overrides' in sub ? sub.overrides : {} };
@@ -212,6 +213,7 @@ export function isInEditorEnv(): boolean {
 	if (isInHook())
 		return false;
 
+	// eslint-disable-next-line ts/no-unnecessary-condition -- codeflow
 	return !!(false
 		|| process.env.VSCODE_PID
 		|| process.env.VSCODE_CWD
@@ -222,6 +224,7 @@ export function isInEditorEnv(): boolean {
 }
 
 export function isInHook(): boolean {
+	// eslint-disable-next-line ts/no-unnecessary-condition -- codeflow
 	return !!(false
 		|| process.env.GIT_PARAMS
 		|| process.env.VSCODE_GIT_COMMAND

packages/eslint/tests/fixtures.test.ts

@@ -114,16 +114,15 @@ function runWithConfig(name: TemplateStringsArray) {
 			const from = resolve(fixturesDir, 'input');
 			const output = resolve(fixturesDir, 'output', name[0]);
 			const target = resolve(outputDir, name[0]);
+			const configString = JSON.stringify(configs);
+			const jsonString = JSON.stringify(items) as any ?? [];
 
 			await fs.copy(from, target, { filter: src => !src.includes('node_modules') });
 			await fs.writeFile(join(target, 'eslint.config.js'), `
 // @eslint-disable
 import { defineConfig } from '@flowr/eslint';
 
-export default defineConfig(
-	${JSON.stringify(configs)},
-	...${JSON.stringify(items) ?? []},
-);
+export default defineConfig(${configString}, ...${jsonString});
 `, 'utf-8');
 
 			if (process.platform === 'win32')

packages/fetch/src/lib/fetch.ts

@@ -186,6 +186,7 @@ function shouldJsonStringify(value: unknown): boolean {
 
 	if (value === null)
 		return true;
+	// eslint-disable-next-line ts/no-unnecessary-condition -- Function can be undefined
 	if (value.constructor === undefined)
 		return true;
 	if (value.constructor === Object)

packages/loader/src/lib/structures/Store.ts

@@ -295,8 +295,8 @@ export class Store<T extends Piece, StoreName extends StoreRegistryKey = StoreRe
 		Store.logger?.(`[STORE => ${this.name}] [INSERT] Loaded new piece '${piece.name}'.`);
 
 		// If the onLoad disabled the piece, call unload and return it:
+		// eslint-disable-next-line ts/no-unnecessary-condition -- side effects from onLoad
 		if (!piece.enabled) {
-			// Unload piece:
 			this.strategy.onUnload(this, piece);
 			await piece.onUnload();
 			Store.logger?.(`[STORE => ${this.name}] [INSERT] Unloaded new piece '${piece.name}' due to 'enabled' being 'false'.`);