Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset rebuilds & missing dependencies #1155

Closed
danielrbradley opened this issue Nov 26, 2024 · 1 comment
Closed

Fix asset rebuilds & missing dependencies #1155

danielrbradley opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@danielrbradley
Copy link
Member

Follow-up to #1151

We've restored the .make tracking files and the binaries, but when running make build_[sdk]:

  • We depend on .make/build_[sdk]
  • Which depends on .make/generate_[sdk]
  • Which depends on .make/schema
  • Which depends on provider/resources.go and provider/go.mod.

These last two are committed files. The timestamps of the restored .make files are from when the prerequisites job ran, however, the commited source files have a modified timestamp of the point at which they were checked out in the second job, which results in the whole dependency chain above being marked as out of date and being rebuilt. The solution to this is probably to use make --touch instead of assets for resuming makefile builds.

Additionally, this problem should also apply to the bin/$(TFGEN) target, but it doesn't because we're missing a dependency from bin/$(TFGEN) on the source files which can affect it (resources.go and any upstream files).

@danielrbradley danielrbradley self-assigned this Nov 26, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 26, 2024
@danielrbradley danielrbradley added kind/bug Some behavior is incorrect or out of spec and removed needs-triage Needs attention from the triage team labels Nov 26, 2024
@danielrbradley danielrbradley changed the title Rebuilds & missing dependencies Assert rebuilds & missing dependencies Nov 26, 2024
@danielrbradley danielrbradley changed the title Assert rebuilds & missing dependencies Fix asset rebuilds & missing dependencies Nov 26, 2024
@danielrbradley danielrbradley added the resolution/fixed This issue was fixed label Nov 27, 2024
@danielrbradley
Copy link
Member Author

Fixed by #1157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

2 participants