Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end release test on ci-mgmt #858

Closed
VenelinMartinov opened this issue Mar 22, 2024 · 5 comments
Closed

End-to-end release test on ci-mgmt #858

VenelinMartinov opened this issue Mar 22, 2024 · 5 comments
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Mar 22, 2024

@t0yv0 proposed we take #857 one step further and have an end-to-end test by checking for end-user behaviour like Pypi binaries, etc.

We might not want to do this on every commit but it sounds totally doable in general.

It should make iterating on changes to our release process much saner.

@t0yv0
Copy link
Member

t0yv0 commented Mar 22, 2024

Something that runs a Pulumi program against a recently published binary in every language would do the trick (with appropriate retry/backoff). As far as I'm aware, the actual capability to publish working programs is not yet tested end to end. Another thing to keep in mind when developing it is that we might want to at some point not only test this to qualify code changes, but also verify actual releases.

@mjeffryes mjeffryes added kind/enhancement Improvements or new features kind/engineering Work that is not visible to an external user and removed kind/enhancement Improvements or new features labels Mar 22, 2024
@t0yv0
Copy link
Member

t0yv0 commented Mar 27, 2024

Lost an AWS release to see untested changes https://github.com/pulumi/pulumi-aws/actions/runs/8454321289

Sadness

@danielrbradley
Copy link
Member

Is this solved by #977 once we've also completed #1035 ?

@VenelinMartinov
Copy link
Contributor Author

Almost, I think this issue was about verifying ci-mgmt changes don't break release processes, so we'd also want to set up a job on xyz to make a release on ci-mgmt PRs and verify they are valid.

@danielrbradley danielrbradley added the resolution/fixed This issue was fixed label Oct 1, 2024
@danielrbradley danielrbradley self-assigned this Oct 1, 2024
@danielrbradley
Copy link
Member

Fixed by #1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants