Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource tags with empty values not created #2195

Closed
kwohlfahrt opened this issue Oct 28, 2022 · 2 comments
Closed

Resource tags with empty values not created #2195

kwohlfahrt opened this issue Oct 28, 2022 · 2 comments
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/duplicate This issue is a duplicate of another issue

Comments

@kwohlfahrt
Copy link

What happened?

I tried to add tags with an empty value to an existing resource, but they were not applied.

Steps to reproduce

Create a subnet as below, but without the tags field. Then, add the tags:

new aws.ec2.Subnet("subnet", {
  vpcId: vpc.id,
  cidrBlock: subnetRange.toCidrString(),
  mapPublicIpOnLaunch: true,
  availabilityZoneId,
  tags: {
    "kubernetes.io/role/elb": "",
    "kubernetes.io/role/internal-elb": "",
  },
}, {provider})

Expected Behavior

I expect the tags to be added.

Actual Behavior

Pulumi did not apply any changes.

Output of pulumi about

CLI          
Version      3.44.2
Go Version   go1.19.2
Go Compiler  gc

Plugins
NAME    VERSION
aws     5.17.0
nodejs  unknown
tls     4.6.1

Host     
OS       darwin
Version  13.0
Arch     arm64

This project is written in nodejs: executable='/Users/kai/.nix-profile/bin/node' version='v16.17.1'

Current Stack: CHARM-Tx/kai

TYPE                                                 URN
<SNIP>

Found no pending operations associated with CHARM-Tx/kai

Backend        
Name           pulumi.com
URL            https://app.pulumi.com/kwohlfahrt
User           kwohlfahrt
Organizations  kwohlfahrt, CHARM-Tx

Dependencies:
NAME                    VERSION
typescript              4.8.3
@charm-tx/pulumi-utils  0.1.4
@pulumi/aws             5.17.0
@types/node             16.11.59
ip-num                  1.4.1
ts-node                 10.9.1
@charm-tx/pulumi-aws    0.1.5
@pulumi/pulumi          3.40.0
@pulumi/tls             4.6.1
zod                     3.19.1

Additional context

Adding a value to the tag (e.g. "1" causes them to be applied correctly). The provider has defaultTags set, but they do not overlap with any of the keys I'm trying to apply in this issue, so I don't think this is related.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@kwohlfahrt kwohlfahrt added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 28, 2022
@roothorp
Copy link
Contributor

roothorp commented Oct 28, 2022

Hey @kwohlfahrt, thanks for the issue! We'll add this to our backlog for future iterations. Thanks!

It is possible this is an upstream issue.

@roothorp roothorp added impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Oct 28, 2022
@mikhailshilkov mikhailshilkov added the resolution/duplicate This issue is a duplicate of another issue label Nov 6, 2023
@mikhailshilkov
Copy link
Member

The upstream issue was supposed to be fixed and released in Pulumi.Aws 6.0. However, there is a similar subsequent issue that is now tracked in #2895.

I'll close this issue in favor of the other one since it has more context on the current status.

@mikhailshilkov mikhailshilkov closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants