Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform-provider-aws to v5.75.1 #4752

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Upgrade terraform-provider-aws to v5.75.1 #4752

merged 3 commits into from
Nov 12, 2024

Conversation

pulumi-bot
Copy link
Contributor

This PR was generated via $ upgrade-provider pulumi/pulumi-aws --kind=all --target-version=5.75.1.

@pulumi-bot pulumi-bot added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Nov 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 3 breaking changes:

Types

  • "aws:apigateway/AccountThrottleSetting:AccountThrottleSetting":
    • 🟡 properties: "burstLimit" type changed from "integer" to "number"
    • required:
      • 🟢 "burstLimit" property has changed to Required
      • 🟢 "rateLimit" property has changed to Required
        No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@flostadler flostadler requested review from t0yv0, corymhall and a team November 12, 2024 13:08
@flostadler flostadler self-assigned this Nov 12, 2024
@t0yv0
Copy link
Member

t0yv0 commented Nov 12, 2024

Good to see the automation got past the patches this time!

t0yv0
t0yv0 reviewed Nov 12, 2024
View reviewed changes
provider/go.mod Outdated
@@ -20,7 +20,7 @@ require (
github.com/hashicorp/terraform-provider-aws v1.60.1-0.20220923175450-ca71523cdc36
github.com/mitchellh/go-homedir v1.1.0
github.com/pulumi/providertest v0.1.3
github.com/pulumi/pulumi-terraform-bridge/v3 v3.94.0
github.com/pulumi/pulumi-terraform-bridge/v3 v3.95.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredibly suspect, we probably should have an issue tracking this. Upstream upgrade automation should not upgrade the bridge. We want to decouple changes as much as possible so we can bisect issues easily.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! I definitely shouldn't do both. Upgrading the bridge to 3.95.0 was already merged, so we don't have an issue here. Just need to rebase the PR

Will cut an issue in upgrade-provider about this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have cut an issue in ci-mgmt already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulumi/ci-mgmt#1141 - I think upgrade-provider can do this, but ci-mgmt is not asking it politely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just found the same: https://github.com/pulumi/ci-mgmt/blob/cf231765a6042eea3c4f9de32c5ecb08f23696b8/provider-ci/internal/pkg/templates/bridged-provider/.github/workflows/upgrade-provider.yml#L83

It should be configured to only upgrade the provider and not all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rebased to remove the bridge upgrade changes from the diff

@t0yv0
Copy link
Member

t0yv0 commented Nov 12, 2024

Also #4702 preventing this from going the whole way.

@t0yv0 t0yv0 mentioned this pull request Nov 12, 2024
Open
@flostadler flostadler force-pushed the upgrade-terraform-provider-aws-to-v5.75.1-66771073 branch from e0036f9 to d470cfc Compare November 12, 2024 15:00
t0yv0
t0yv0 reviewed Nov 12, 2024
View reviewed changes
patches/0076-Patch-computed-only-tags-for-iot-billing_group.patch
@@ -5,7 +5,7 @@ Subject: [PATCH] Patch computed only tags for iot/billing_group


diff --git a/internal/service/iot/billing_group.go b/internal/service/iot/billing_group.go
index 90d64baff5..dd84f3acb3 100644
index 90d64baff5a..dd84f3acb33 100644
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be lovely if commits were not recorded and wouldn't churn, not sure if feasible though.

@flostadler flostadler merged commit 0e03d6a into master Nov 12, 2024
33 checks passed
@flostadler flostadler deleted the upgrade-terraform-provider-aws-to-v5.75.1-66771073 branch November 12, 2024 18:56
@pulumi-bot
Copy link
Contributor Author

This PR has been shipped in release v6.59.1.

@pulumi-bot pulumi-bot mentioned this pull request Nov 12, 2024
Closed
@github-actions github-actions bot removed the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flostadler flostadler flostadler left review comments

@t0yv0 t0yv0 t0yv0 approved these changes

@corymhall corymhall Awaiting requested review from corymhall

Assignees

@flostadler flostadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.75.1
3 participants
@pulumi-bot @t0yv0 @flostadler