Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum annotations missing in discovery and SDKs #868

Open
mikhailshilkov opened this issue Apr 27, 2023 · 0 comments
Open

Enum annotations missing in discovery and SDKs #868

mikhailshilkov opened this issue Apr 27, 2023 · 0 comments
Labels
kind/enhancement Improvements or new features upstream/discovery

Comments

@mikhailshilkov
Copy link
Member

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Enum annotations are missing for some resources. Two examples that I recently found:

  • apikeys.Key has a location property which can take any string. However, the discovery doc has a comment: Key is a global resource; hence the only supported value for location is "global"..
  • eventarc.Trigger has an operator property which can take any string. However, the discovery doc has a comment: The only allowed value is "match-path-pattern"..

It would be nice if discovery docs had an annotation for these properties, and they would be respected in the SDKs.

@mikhailshilkov mikhailshilkov added kind/enhancement Improvements or new features upstream/discovery labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features upstream/discovery
Projects
None yet
Development

No branches or pull requests

1 participant