Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul logging #354

Closed
4 tasks done
squaremo opened this issue Oct 25, 2022 · 1 comment · Fixed by #742
Closed
4 tasks done

Overhaul logging #354

squaremo opened this issue Oct 25, 2022 · 1 comment · Fixed by #742
Assignees
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@squaremo
Copy link
Contributor

squaremo commented Oct 25, 2022

The logging is inconsistent (which makes it difficult to eyeball, and to use for any automation); and, not always very purposeful.

Ongoing wishlist:

  • There are duplicate labels, e.g., "namespace" is supplied when it's already been set on the reqLogger
  • The default level in configs should be info, rather than error -- people get confused when they run it and see no logs (because nothing bad is happening)
  • The use of labels is inconsistent, both in which labels are used, and how they are spelt (especially with respect to case)
  • The position and content of log messages should be audited -- does each log message tell the user something useful?
@squaremo squaremo added the impact/usability Something that impacts users' ability to use the product easily and intuitively label Oct 25, 2022
@dirien
Copy link
Contributor

dirien commented Dec 20, 2022

Some additional infos to log from a customer feedback:

  • When a new run starts
  • When a reconcile check happens and its result

@mnlumi mnlumi added the kind/enhancement Improvements or new features label Jul 21, 2023
@EronWright EronWright self-assigned this Nov 6, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants