Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New commits not detected #762

Closed
blampe opened this issue Nov 26, 2024 · 0 comments · Fixed by #763
Closed

New commits not detected #762

blampe opened this issue Nov 26, 2024 · 0 comments · Fixed by #763
Assignees
@blampe
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team resolution/fixed This issue was fixed

Comments

@blampe
Copy link
Contributor

blampe commented Nov 26, 2024

What happened?

The operator doesn't currently requeue in cases where we're using git sources. This means we don't detect new commits.

Example

...

Output of pulumi about

...

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@blampe blampe added the kind/bug Some behavior is incorrect or out of spec label Nov 26, 2024
@blampe blampe self-assigned this Nov 26, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 26, 2024
@blampe blampe mentioned this issue Nov 26, 2024
Merged
EronWright added a commit that referenced this issue Nov 27, 2024
@blampe @EronWright
Fix requeue for git commit tracking (#763)
09f8484 
Fixes a bug where we were accidentally cancelling a requeue when we
intended to poll again after a minute.

Fixes #762.

---------

Co-authored-by: Eron Wright <eron@pulumi.com>
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blampe blampe

Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix requeue for git commit tracking pulumi/pulumi-kubernetes-operator
2 participants
@blampe @pulumi-bot