Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in code gen for constructor params of Python overlay resources #1082

Open
Tracked by #2787
praneetloke opened this issue Apr 22, 2020 · 1 comment
Open
Tracked by #2787
Labels
area/sdk Related to the Kubernetes SDKs (nodejs, Python, etc.) kind/bug Some behavior is incorrect or out of spec language/python mro1 Monica's list of 1st tier overlay related issues

Comments

@praneetloke
Copy link
Contributor

praneetloke commented Apr 22, 2020

Related to pulumi/pulumi#4464 and #1072.

The input properties for each of the overlay resources are not consistent among themselves and not consistent with how the Pulumi schema-based code gen would generate them. I don't know if this is something we can actually fix since overlay resources aren't really schematized, but wanted to track the differences somewhere. If these are things we can bring alignment on, we can avoid having manual exclusions to generate docs for these.

  • The opts param ordering is not consistent. Sometimes appears after all input properties, and other times not. Even then it is out-of-sync with how the schema-based code gen would generate it.
  • Between the NodeJS and the Python SDKs, the params of the apiextensions.CustomResource are not the same.
    • For instance, in Python there is an extra input property called spec, which is not accepted as an input prop in the NodeJS SDK.
    • The othersFields property available in NodeJS isn't there in the Python SDK. I am not a Python expert here, but I would have expected to be able to pass a dictionary similar to the map in the NodeJS SDK.
@praneetloke
Copy link
Contributor Author

cc @lblackstone

@lblackstone lblackstone self-assigned this Apr 22, 2020
@lblackstone lblackstone added area/sdk Related to the Kubernetes SDKs (nodejs, Python, etc.) language/python labels Apr 22, 2020
@mnlumi mnlumi added the mro1 Monica's list of 1st tier overlay related issues label Mar 28, 2023
@lblackstone lblackstone removed their assignment Jul 14, 2023
@lblackstone lblackstone added the kind/bug Some behavior is incorrect or out of spec label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk Related to the Kubernetes SDKs (nodejs, Python, etc.) kind/bug Some behavior is incorrect or out of spec language/python mro1 Monica's list of 1st tier overlay related issues
Projects
None yet
Development

No branches or pull requests

3 participants