Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Tests not catching outdated tests/go.{mod,sum} until after merging to master #1530

Closed
lblackstone opened this issue Apr 16, 2021 · 1 comment
Closed

[ci] Tests not catching outdated tests/go.{mod,sum} until after merging to master #1530

lblackstone opened this issue Apr 16, 2021 · 1 comment
Assignees
@stack72
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@lblackstone
Copy link
Member

Expected behavior

All go.mod files are checked prior to tests passing.

Current behavior

Here's an example: #1521 updated the go.mod files, but the CI tests passed until after merging to master.

This was subsequently fixed in fc1a935
@lblackstone lblackstone added the kind/bug Some behavior is incorrect or out of spec label Apr 16, 2021
@lblackstone
Copy link
Member Author

I think the make ensure target got deleted at some point, but adding that might be a useful way to avoid this during development.

@lblackstone lblackstone added the resolution/fixed This issue was fixed label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stack72 stack72

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stack72 @lblackstone