Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster tuning env vars don't work for Node or Go #1766

Closed
lblackstone opened this issue Oct 13, 2021 · 0 comments · Fixed by #1777
Closed

Cluster tuning env vars don't work for Node or Go #1766

lblackstone opened this issue Oct 13, 2021 · 0 comments · Fixed by #1777
Assignees
@viveklak
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.63

Comments

@lblackstone
Copy link
Member

Hello!

  • Vote on this issue by adding a 👍 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

See #1748 (comment) for details

As a result of a codegen bug, the environment variables for the cluster tuning parameters added in #1748 don't work for the Node or Go SDKs.

Until the codegen bug is fixed, we need to explicitly handle these env vars in the provider.
@lblackstone lblackstone added the kind/bug Some behavior is incorrect or out of spec label Oct 13, 2021
@lblackstone lblackstone added this to the 0.63 milestone Oct 13, 2021
@viveklak viveklak self-assigned this Oct 13, 2021
@viveklak viveklak mentioned this issue Oct 25, 2021
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viveklak viveklak

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.63
Development

Successfully merging a pull request may close this issue.

Add env variable lookup for k8s client settings pulumi/pulumi-kubernetes
3 participants
@viveklak @lblackstone @pulumi-bot