Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellation on delete could cause us to stop tracking object #245

Closed
2 tasks done
hausdorff opened this issue Oct 19, 2018 · 2 comments
Closed
2 tasks done

Cancellation on delete could cause us to stop tracking object #245

hausdorff opened this issue Oct 19, 2018 · 2 comments
Assignees
Labels
area/resource-management Issues related to Kubernetes resource provisioning, management, await logic, and semantics generally kind/bug Some behavior is incorrect or out of spec
Milestone

Comments

@hausdorff
Copy link
Contributor

hausdorff commented Oct 19, 2018

Following up from #244, in the process of review, I realized that in a handful of cases, it is possible that ctrl-c during a delete could cause the Kubernetes provider to stop tracking the object, even though it exists.

The reason is that provider does not actually check whether the returned value conforms to await.InitializationError, which is what the await package uses to signal that the API server has acknowledged the operation, but has not yet completed it.

The fix seems pretty straightforward:

@lukehoban
Copy link
Contributor

@hausdorff How serious is this in practice? Have users hit this? Do we need to make sure to fix in 0.19?

@hausdorff
Copy link
Contributor Author

This is very minor, you'd have to get very unlucky. But, we should solve it, let's put it into 0.20

@hausdorff hausdorff modified the milestones: 0.19, 0.20 Nov 19, 2018
@hausdorff hausdorff added kind/bug Some behavior is incorrect or out of spec area/resource-management Issues related to Kubernetes resource provisioning, management, await logic, and semantics generally priority/P2 labels Dec 18, 2018
@hausdorff hausdorff modified the milestones: 0.20, 0.21 Dec 18, 2018
@joeduffy joeduffy modified the milestones: 0.21, 0.20 Dec 30, 2018
@hausdorff hausdorff assigned lblackstone and unassigned hausdorff Jan 7, 2019
@lukehoban lukehoban modified the milestones: 0.20, 0.21 Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-management Issues related to Kubernetes resource provisioning, management, await logic, and semantics generally kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

4 participants