Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemagen should be able to recursively generate types #3149

Closed
rquitales opened this issue Aug 2, 2024 · 2 comments · Fixed by #3187
Closed

Schemagen should be able to recursively generate types #3149

rquitales opened this issue Aug 2, 2024 · 2 comments · Fixed by #3187
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@rquitales
Copy link
Member

Issue details

The current obtained Kubernetes schemas have flat objects, and nested objects are not inlined. Schemagen works fine on such upstream OpenAPI specs. However, CRDs tend to have inlined object definitions that schemagen will treat as an unstructured object, thus making the generated types lossy. We should enable recursive generating nested object types.

Affected area/feature

Codegen

@rquitales rquitales added the kind/enhancement Improvements or new features label Aug 2, 2024
@cleverguy25
Copy link

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 2, 2024
@rquitales rquitales removed the needs-triage Needs attention from the triage team label Aug 5, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 12, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #3187 and shipped in release v4.18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants