Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: skipAwait: true should only skip readiness #3154

Open
blampe opened this issue Aug 7, 2024 · 0 comments
Open

v5: skipAwait: true should only skip readiness #3154

blampe opened this issue Aug 7, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Aug 7, 2024

skipAwait behavior when applied to deletes is racy and often not what you want -- usually a background cascade is more appropriate. See Eron's comment here.

We should re-evaluate the default behavior of the skipAwait annotation in v5. Some options:

  • Make skipAwait only apply to readiness, and don't use it at all for deletes. Have the user specify pulumi.com/deletionPropagationPolicy to change delete behavior.
  • Make skipAwait apply to readiness and delete, but for deletions treat interpret it as a background delete. Fewer annotations for the user to have to know about.

Worth mentioning one (questionable) use for skipAwait with delete today is that it allows the user to skip stuck finalizers, which should generally be avoided but is sometimes necessary. Related #3153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant