Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to disable statefulSet await logic #428

Closed
beetahnator opened this issue Feb 13, 2019 · 3 comments
Closed

Add toggle to disable statefulSet await logic #428

beetahnator opened this issue Feb 13, 2019 · 3 comments

Comments

@beetahnator
Copy link
Contributor

beetahnator commented Feb 13, 2019

Some stateful services take 12+ hours to become ready, causing deployments to never apply all changes (stale resources are not deleted since the resource creation keeps failing).

Also, most statefulSet rolling updates take longer to complete than the timeout allows (especially once you go over 5 replicas)

Diagnostics:
  kubernetes:apps:StatefulSet (XXXXXX-0163):
    error: Preview failed: 2 errors occurred:

    * Resource 'XXXXXXX-0163' was created but failed to initialize
    * Failed to observe the expected number of ready replicas

Configureable timeout values are good, but being able to disable these checks is more necessary.

@beetahnator beetahnator changed the title Add toggle to disable ready replica count checks Add toggle to disable statefulSet await logic Feb 13, 2019
@lblackstone
Copy link
Member

@mazamats #417 just merged, which will do what you need. I'm planning to cut an official release today, but you can try it out now with @pulumi/kubernetes: dev.

To use it, just add the following annotation to the relevant resource: pulumi.com/skipAwait: true.

const pod = new k8s.core.v1.Pod("pod", {
    metadata: {
        annotations: {
            "pulumi.com/skipAwait": "true"
        }
    },
    spec: {
        containers: [
            {name: "nginx", image: "nginx:1.13-alpine"},
        ],
    },
});

@lblackstone
Copy link
Member

We will likely add configurable timeouts as well for more fine-grained control.

@lblackstone
Copy link
Member

Release 0.20.2 is out now, and includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants