Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Pod awaiter #450

Closed
lblackstone opened this issue Feb 25, 2019 · 0 comments · Fixed by #590
Closed

Simplify Pod awaiter #450

lblackstone opened this issue Feb 25, 2019 · 0 comments · Fixed by #590
Assignees
@lblackstone
Labels
area/await-logic kind/engineering Work that is not visible to an external user
Milestone
0.24

Comments

@lblackstone
Copy link
Member

Refactor the complex await logic as prototyped in #343.

  1. Convert unstructured k8s objects to their structured counterparts
  2. Factor state checking into dedicated Condition functions

Prototype gist: https://gist.github.com/lblackstone/fe58ad48eb9ce48bb96000af8c6e0791
@lblackstone lblackstone added this to the 0.21 milestone Feb 25, 2019
@lblackstone lblackstone self-assigned this Feb 25, 2019
@lblackstone lblackstone mentioned this issue Feb 25, 2019
Closed
@lblackstone lblackstone modified the milestones: 0.21, 0.22 Mar 6, 2019
@lblackstone lblackstone removed this from the 0.22 milestone Mar 22, 2019
@lblackstone lblackstone added this to the 0.23 milestone Apr 26, 2019
@lukehoban lukehoban modified the milestones: 0.23, 0.24 May 28, 2019
@lblackstone lblackstone mentioned this issue Jun 10, 2019
Merged
@lblackstone lblackstone mentioned this issue Jul 9, 2019
Merged
@infin8x infin8x added the kind/engineering Work that is not visible to an external user label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lblackstone lblackstone

Labels
area/await-logic kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
0.24
Development

Successfully merging a pull request may close this issue.

Refactor Pod await logic pulumi/pulumi-kubernetes
3 participants
@lukehoban @infin8x @lblackstone