Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Job awaiter error and warning reporting #822

Closed
metral opened this issue Sep 30, 2019 · 1 comment · Fixed by #832
Closed

Improve Job awaiter error and warning reporting #822

metral opened this issue Sep 30, 2019 · 1 comment · Fixed by #832
Assignees
Labels
area/await-logic kind/enhancement Improvements or new features
Milestone

Comments

@metral
Copy link
Contributor

metral commented Sep 30, 2019

Problem description

The structure of warning messages during a job await is not intuitive when failures or errors arise. Consider rearranging how the message is structured to inform the user of the diagnostics seen up to now, instead of the warning alone.

Errors & Logs

Affected product version(s)

#633 / soon-to-be master

Suggestions for a fix

#633 (comment)

@metral metral added this to the 0.28 milestone Sep 30, 2019
@metral metral added kind/enhancement Improvements or new features area/await-logic labels Sep 30, 2019
This was referenced Oct 3, 2019
@lblackstone
Copy link
Member

Appending warnings to the status message would have required nontrivial changes, so I decided to limit the scope to the most common case: containers with unready status

Since this "warning" is a normal part of every Pod's lifecycle, I skipped printing it unless the Job failed to become ready. This cuts down on noise, and should only print warnings that adversely impact readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/await-logic kind/enhancement Improvements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants