Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct nil MaxItemsOne handling in the bridge #1767

Closed
VenelinMartinov opened this issue Mar 18, 2024 · 1 comment · Fixed by #1971
Closed

Correct nil MaxItemsOne handling in the bridge #1767

VenelinMartinov opened this issue Mar 18, 2024 · 1 comment · Fixed by #1971
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

The root cause pulumi/pulumi-aws#3427 seems to be that in Create and Update we pass nil for unspecified MaxItemsOne properties while in most cases TF passes an empty collection. See pulumi/pulumi-aws#3427 (comment) for details.

We tried to address in #1725 but hit #1762 which causes a panic in Azure, so a blocker for further progress here.

We should address this.

A painful point here was that iteration was extremely painful. We have practically no tests around this in the bridge and downstream tests revealed multiple issues and subtleties. We might want to start with some pulumi->TF cross tests like in #1728.

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov
Copy link
Contributor Author

Blocked by #1762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants