Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a strategy to deal with changes to aws tagging #206

Closed
stack72 opened this issue May 19, 2020 · 4 comments
Closed

Decide on a strategy to deal with changes to aws tagging #206

stack72 opened this issue May 19, 2020 · 4 comments
Assignees
Milestone

Comments

@stack72
Copy link
Contributor

stack72 commented May 19, 2020

This PR hashicorp/terraform-provider-aws#13233 introduced breaking changes to our tags

We reverted the commit in our fork but we need to come up with a strategy to mitigate the breaking changes

@leezen leezen added this to the 0.37 milestone May 27, 2020
@leezen leezen modified the milestones: 0.37, current Jun 7, 2020
@mikhailshilkov
Copy link
Member

@stack72 Given your PR today, is this task "done"?

@stack72
Copy link
Contributor Author

stack72 commented Jun 22, 2020

@mikhailshilkov nah, there's still a doc / guidance from @lukehoban outstanding. The issue we ad to fix in my PR was that there are 3 reported cases of panics due to the code we reverted :/ So we reverted to stop people getting broken but actually broke them in a different way

We need to rectify that and continue to look at things on a case by case basis

@lukehoban
Copy link
Contributor

Actually - I think this one is done. https://github.com/pulumi/home/issues/877 is tracking a document on breaking change policy more broadly. Is that right @stack72?

@stack72
Copy link
Contributor Author

stack72 commented Jun 22, 2020

Oh you are correct - I didn’t see the dupe! Sorry @mikhailshilkov :)

@stack72 stack72 closed this as completed Jun 22, 2020
@leezen leezen modified the milestones: current, 0.38 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants