Enable remote publishing #6097
Enable remote publishing #6097
Conversation
iwahbe
force-pushed
the
iwahbe/enable-remote-publishing
branch
from
dd45c7c
to
24cef21
Compare
iwahbe
force-pushed
the
iwahbe/enable-remote-publishing
branch
from
24cef21
to
b9e90cc
Compare
|
Your site preview for commit dd45c7c is ready! 🎉 http://registry--origin-pr-6097-dd45c7c6.s3-website.us-west-2.amazonaws.com/registry. |
|
Your site preview for commit 24cef21 is ready! 🎉 http://registry--origin-pr-6097-24cef219.s3-website.us-west-2.amazonaws.com/registry. |
|
Your site preview for commit b9e90cc is ready! 🎉 http://registry--origin-pr-6097-b9e90cc6.s3-website.us-west-2.amazonaws.com/registry. |
| - name: Validate Inputs | ||
| run: | | ||
| if ![ "${{ env.PROVIDER_VERSION }} = "" ]; then echo "PROVIDER_VERSION is not respected; exit 1; fi | ||
| if ![ "${{ env.PROVIDER_SCHEMA_PATH }} = "" ]; then echo "PROVIDER_VERSION is not respected; exit 1; fi |
There was a problem hiding this comment.
| if ![ "${{ env.PROVIDER_SCHEMA_PATH }} = "" ]; then echo "PROVIDER_VERSION is not respected; exit 1; fi | |
| if ![ "${{ env.PROVIDER_SCHEMA_PATH }} = "" ]; then echo "PROVIDER_SCHEMA_PATH is not respected; exit 1; fi |
Also I don't speak fluent bash but that doesn't look right to me with the placement of the quotes.
I also can't tell without context what are we asserting. If I ran into this error, I wouldn't know what do do next.
| - resource-provider | ||
| # An update for a provider that is hosted opaquely. |
There was a problem hiding this comment.
This is a new term - presumbably referring to third-party and dynamic providers? Could we make this clear?
Or just say "hosted elsewhere".
This PR adds a repository dispatch target to accept incoming docs PRs for providers without host repositories.
Unfortunately, I'm not able to test dispatch events without them being present on the default branch. For risk mitigation: