Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not to use new keyword anymore, and clean them out for next release? #41

Open
m1-nann opened this issue Jan 6, 2019 · 1 comment
Open

not to use new keyword anymore, and clean them out for next release? #41

m1-nann opened this issue Jan 6, 2019 · 1 comment

Comments

@m1-nann
Copy link

m1-nann commented Jan 6, 2019

I know it's optional, but should we put this on plan? new keyword is discourage in Dart Usage guideline as well:

https://www.dartlang.org/guides/language/effective-dart/usage#dont-use-new
@pulyaevskiy
Copy link
Owner

You're right, this needs to be cleaned up.

I haven't done this yet because analyzer had an issue with handling Map objects in Dart 2.0 so I just left it as is, it might have changed in 2.1 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pulyaevskiy @m1-nann