Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt_key can not deal with options #1102

Closed
tuxmea opened this issue Apr 21, 2023 · 2 comments · May be fixed by #1103
Closed

apt_key can not deal with options #1102

tuxmea opened this issue Apr 21, 2023 · 2 comments · May be fixed by #1103
Labels
community

Comments

@tuxmea
Copy link

tuxmea commented Apr 21, 2023

Describe the Bug

We want to use the apt_key resource type using source and we want to provide proxy options.

Expected Behavior

Proxy is used

Environment

  • Version PE 2021.7.1 - Puppet 7
  • Platform Ubuntu 20

Additional Context

see https://github.com/puppetlabs/puppetlabs-apt/blob/main/lib/puppet/provider/apt_key/apt_key.rb#L194
This if statement matches only if source and content are both nil.
If either one is set the options will not be added to the command.
tuxmea added a commit to tuxmea/puppetlabs-apt that referenced this issue Apr 22, 2023
@tuxmea
Allow setting keyserver options (like proxy) when using source
fcd1767 
fixes puppetlabs#1102
@tuxmea tuxmea mentioned this issue Apr 22, 2023
Open
@kenyon
Copy link

kenyon commented Apr 22, 2023

Looks the same as #1037.

@tuxmea
Copy link
Author

tuxmea commented Apr 23, 2023

duplicate of #1037

@tuxmea tuxmea closed this as completed Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow setting keyserver options (like proxy) when using source tuxmea/puppetlabs-apt
3 participants
@kenyon @tuxmea @ia-content