From 371eab3bb39c7dd553672bea1279203ded788fa3 Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Tue, 30 May 2023 17:13:14 +0100 Subject: [PATCH 1/3] (CONT-1028) puppetlabs/stdlib: Allow 9.x --- metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata.json b/metadata.json index 076f068de1..48487aaa50 100644 --- a/metadata.json +++ b/metadata.json @@ -10,7 +10,7 @@ "dependencies": [ { "name": "puppetlabs/stdlib", - "version_requirement": ">= 4.16.0 < 9.0.0" + "version_requirement": ">= 4.16.0 < 10.0.0" } ], "operatingsystem_support": [ From 2b9b9da268bb1c7aecbabde97b894274df7862a9 Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Wed, 31 May 2023 12:26:08 +0100 Subject: [PATCH 2/3] Switch from merge() to native puppet --- manifests/init.pp | 14 +++++--------- manifests/source.pp | 6 +++--- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/manifests/init.pp b/manifests/init.pp index cd408d8f67..a8b666e8f7 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -200,7 +200,7 @@ assert_type(Integer, $update['tries']) } - $_update = merge($apt::update_defaults, $update) + $_update = $apt::update_defaults + $update include apt::update if $purge['sources.list'] { @@ -222,11 +222,11 @@ assert_type(Boolean, $purge['apt.conf.d']) } - $_purge = merge($apt::purge_defaults, $purge) + $_purge = $apt::purge_defaults + $purge if $proxy['perhost'] { $_perhost = $proxy['perhost'].map |$item| { - $_item = merge($apt::proxy_defaults, $item) + $_item = $apt::proxy_defaults + $item $_scheme = $_item['https'] ? { true => 'https', default => 'http', @@ -239,17 +239,13 @@ true => 'DIRECT', default => "${_scheme}://${_item['host']}${_port}/", } - merge($item, { - 'scheme' => $_scheme, - 'target' => $_target, - } - ) + $item + { 'scheme' => $_scheme, 'target' => $_target, } } } else { $_perhost = {} } - $_proxy = merge($apt::proxy_defaults, $proxy, { 'perhost' => $_perhost }) + $_proxy = $apt::proxy_defaults + $proxy + { 'perhost' => $_perhost } $confheadertmp = epp('apt/_conf_header.epp') $proxytmp = epp('apt/proxy.epp', { 'proxies' => $_proxy }) diff --git a/manifests/source.pp b/manifests/source.pp index 420d19d451..6d16b5ef5c 100644 --- a/manifests/source.pp +++ b/manifests/source.pp @@ -114,7 +114,7 @@ $_location = undef } - $includes = merge($apt::include_defaults, $include) + $includes = $apt::include_defaults + $include if $key and $keyring { fail('parameters key and keyring are mutualy exclusive') @@ -125,7 +125,7 @@ unless $key['id'] { fail('key hash must contain at least an id entry') } - $_key = merge($apt::source_key_defaults, $key) + $_key = $apt::source_key_defaults + $key } else { $_key = { 'id' => assert_type(String[1], $key) } } @@ -164,7 +164,7 @@ if $pin { if $pin =~ Hash { - $_pin = merge($pin, { 'ensure' => $ensure, 'before' => $_before }) + $_pin = $pin + { 'ensure' => $ensure, 'before' => $_before } } elsif ($pin =~ Numeric or $pin =~ String) { $url_split = split($location, '[:\/]+') $host = $url_split[1] From c0b8640fc6a7c3381877863960e02da3fa1fe640 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Mon, 5 Jun 2023 09:37:05 +0200 Subject: [PATCH 3/3] ensure_packages: switch to stdlib::ensure_packages --- manifests/init.pp | 4 ++-- manifests/key.pp | 4 ++-- manifests/ppa.pp | 2 +- manifests/source.pp | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/manifests/init.pp b/manifests/init.pp index a8b666e8f7..b30b418d72 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -382,12 +382,12 @@ case $facts['os']['name'] { 'Debian': { if versioncmp($facts['os']['release']['major'], '9') >= 0 { - ensure_packages(['gnupg']) + stdlib::ensure_packages(['gnupg']) } } 'Ubuntu': { if versioncmp($facts['os']['release']['full'], '17.04') >= 0 { - ensure_packages(['gnupg']) + stdlib::ensure_packages(['gnupg']) } } default: { diff --git a/manifests/key.pp b/manifests/key.pp index f6c2f6161b..9d3106dbd5 100644 --- a/manifests/key.pp +++ b/manifests/key.pp @@ -65,13 +65,13 @@ case $facts['os']['name'] { 'Debian': { if versioncmp($facts['os']['release']['major'], '9') >= 0 { - ensure_packages(['gnupg']) + stdlib::ensure_packages(['gnupg']) Apt::Key<| title == $title |> } } 'Ubuntu': { if versioncmp($facts['os']['release']['full'], '17.04') >= 0 { - ensure_packages(['gnupg']) + stdlib::ensure_packages(['gnupg']) Apt::Key<| title == $title |> } } diff --git a/manifests/ppa.pp b/manifests/ppa.pp index 2a5b4a868d..61caa34e5f 100644 --- a/manifests/ppa.pp +++ b/manifests/ppa.pp @@ -73,7 +73,7 @@ if $ensure == 'present' { if $package_manage { - ensure_packages($package_name) + stdlib::ensure_packages($package_name) $_require = [File['sources.list.d'], Package[$package_name]] } else { $_require = File['sources.list.d'] diff --git a/manifests/source.pp b/manifests/source.pp index 6d16b5ef5c..2386c0a5f3 100644 --- a/manifests/source.pp +++ b/manifests/source.pp @@ -107,7 +107,7 @@ # Newer oses, do not need the package for HTTPS transport. $_transport_https_releases = ['9'] if (fact('os.release.major') in $_transport_https_releases) and $_location =~ /(?i:^https:\/\/)/ { - ensure_packages('apt-transport-https') + stdlib::ensure_packages('apt-transport-https') Package['apt-transport-https'] -> Class['apt::update'] } } else {