-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aws profile prompt #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the MR.
I updated the inital post to fix the links to the files to update.
@kwigley Any reason you closed the MR? |
Nope, just wanted to make sure I updated docs before submitting PR. I'll reopen and add you're feedback. Thanks! |
@edouard-lopez ready for another look, didn't add any feature tests because this is just looking for an env var, but let me know if you would like me to add one. |
|
I had some difficulties pushing to your repo. When I finally managed to do it, I pushed pure/master in your repo/master which closed this PR. And I'm unable to push to your repo anymore. I created a new PR with your commits in #348 |
Adds the currently active aws profile to prompt.
How to test pre-release?
First contribution?
Check the 👍 contributing guide for code and naming conventions.
Specs
New config in
conf.d/pure.fish
Documentation
Usage
Acceptance Checks
conf.d/pure.fish
for:tests/feature_name.test.fish
;