Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aws profile prompt #346

Closed
wants to merge 0 commits into from
Closed

feat: aws profile prompt #346

wants to merge 0 commits into from

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Jan 29, 2024

Adds the currently active aws profile to prompt.

How to test pre-release?

☠️ Feature can be unstable and break your prompt!

fisher install pure-fish/pure@feat/foo_feature # branch name
set --universal pure_enable_foo_feature true

First contribution?

Check the 👍 contributing guide for code and naming conventions.

Specs

New config in conf.d/pure.fish

_pure_set_default pure_enable_aws_profile true
_pure_set_default pure_symbol_aws_profile "🤯"

Documentation

Usage

set --universal pure_enable_aws_profile true

Acceptance Checks

  • Documentation is up-to-date:
    • Add entry in feature list of README.md ;
    • Add entry in features' overview in docs/ ;
    • Add section in feature list to document
      • Features' flag ;
      • Prompt symbol ;
  • Default are defined in conf.d/pure.fish for:
    • Feature flag ;
    • Symbol ;
  • Tests are passing (I can help you 🤗 ):
  • Customization is available ;
  • Feature is implemented.

@kwigley kwigley closed this Jan 29, 2024
Copy link
Member

@edouard-lopez edouard-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MR.
I updated the inital post to fix the links to the files to update.

conf.d/pure.fish Outdated Show resolved Hide resolved
functions/_pure_prompt.fish Outdated Show resolved Hide resolved
functions/_pure_prompt.fish Outdated Show resolved Hide resolved
@edouard-lopez
Copy link
Member

@kwigley Any reason you closed the MR?

@edouard-lopez edouard-lopez added the ⭐️ idea feature request or suggestion label Jan 30, 2024
@kwigley
Copy link
Contributor Author

kwigley commented Jan 30, 2024

Nope, just wanted to make sure I updated docs before submitting PR. I'll reopen and add you're feedback. Thanks!

@kwigley kwigley reopened this Jan 30, 2024
@kwigley kwigley marked this pull request as ready for review January 30, 2024 15:13
@kwigley
Copy link
Contributor Author

kwigley commented Jan 30, 2024

@edouard-lopez ready for another look, didn't add any feature tests because this is just looking for an env var, but let me know if you would like me to add one.

@kwigley kwigley changed the title feat: awsprofile prompt feat: aws profile prompt Jan 30, 2024
@edouard-lopez
Copy link
Member

edouard-lopez commented Feb 16, 2024

Could you allow push to your fork so I can add the feature tests?

@edouard-lopez edouard-lopez mentioned this pull request Feb 16, 2024
14 tasks
@edouard-lopez
Copy link
Member

I had some difficulties pushing to your repo. When I finally managed to do it, I pushed pure/master in your repo/master which closed this PR. And I'm unable to push to your repo anymore.

I created a new PR with your commits in #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ idea feature request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants