Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't expand a watch variable after 'restart' command #789

Closed
2 tasks done
Aster89 opened this issue Aug 16, 2023 · 3 comments · Fixed by #790
Closed
2 tasks done

Can't expand a watch variable after 'restart' command #789

Aster89 opened this issue Aug 16, 2023 · 3 comments · Fixed by #790
Labels
bug Something isn't working Severity 2 The plugin or a workflow is inconvenient or occasionally broken

Comments

@Aster89
Copy link
Contributor

Aster89 commented Aug 16, 2023

Description

Hitting Enter on a +able line in the watchers window doesn't work after the debugger has been restarted.

Works in vim?

Reproducable in Vim

Works with clean config?

Yes

Sample project works?

No sample project for this filetype

Minimal Reproduction

List of steps to reproduce:

  1. Run vim --clean -Nu ~/.vim/plugged/vimspector/support/minimal_vimrc ranges.cpp some-file-with-some-local-var.cpp
  2. Set a breakpoint
  3. Start the debugger
  4. Set a watcher for a non-bultin variable in scope
  5. Expand a few levels but not all
  6. Restart the debugger (you'll stop to the same BP as before)
  7. Try to expand some +able line in the watcher window.

Here's the screencast:
asciicast

Expected Behaviour

Expanding in the watchers win should work.

Actual Behaviour

It doens't.

Additional information

No response

Installation Type

Plugin Manager (git clone)

Vimspector version

937ef5b

Debug Info

No response

Log file

No response

Vim version

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Aug 07 2023 19:52:44)
Included patches: 1-1678
Compiled by Arch Linux
Huge version with GTK3 GUI.  Features included (+) or not (-):
+acl               +channel           +cscope            +ex_extra          -hangul_input      +linebreak         +mouse_dec         -mzscheme          +profile           -sodium            +tcl/dyn           +user_commands     +wildmenu
+arabic            +cindent           +cursorbind        +extra_search      +iconv             +lispindent        +mouse_gpm         +netbeans_intg     -python            +sound             +termguicolors     +vartabs           +windows
+autocmd           +clientserver      +cursorshape       -farsi             +insert_expand     +listcmds          -mouse_jsbterm     +num64             +python3/dyn       +spell             +terminal          +vertsplit         +writebackup
+autochdir         +clipboard         +dialog_con_gui    +file_in_path      +ipv6              +localmap          +mouse_netterm     +packages          +quickfix          +startuptime       +terminfo          +vim9script        +X11
-autoservername    +cmdline_compl     +diff              +find_in_path      +job               +lua/dyn           +mouse_sgr         +path_extra        +reltime           +statusline        +termresponse      +viminfo           -xfontset
+balloon_eval      +cmdline_hist      +digraphs          +float             +jumplist          +menu              -mouse_sysmouse    +perl/dyn          +rightleft         -sun_workshop      +textobjects       +virtualedit       +xim
+balloon_eval_term +cmdline_info      +dnd               +folding           +keymap            +mksession         +mouse_urxvt       +persistent_undo   +ruby/dyn          +syntax            +textprop          +visual            -xpm
+browse            +comments          -ebcdic            -footer            +lambda            +modify_fname      +mouse_xterm       +popupwin          +scrollbind        +tag_binary        +timers            +visualextra       +xsmp_interact
++builtin_terms    +conceal           +emacs_tags        +fork()            +langmap           +mouse             +multi_byte        +postscript        +signs             -tag_old_static    +title             +vreplace          +xterm_clipboard
+byte_offset       +cryptv            +eval              +gettext           +libcall           +mouseshape        +multi_lang        +printer           +smartindent       -tag_any_white     +toolbar           +wildignore        -xterm_save
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "/etc/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/lib
png16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-at
k/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -pthread -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -g -ffile-prefix-map=/build
/vim/src=/usr/src/debug/vim -flto=auto -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc -Wl,-E -Wl,-rpath,/usr/lib/perl5/5.38/core_perl/CORE -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto -L/usr/local/lib -o vim -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixb
uf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lSM -lICE -lXt -lX11 -lXdmcp -lSM -lICE -lm -ltinfo -lelf -lcanberra -lacl -lattr -lgpm -Wl,-E -Wl,-rpath,/usr/lib/perl5/5.38/core_perl/CORE -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto -fstack-pr
otector-strong -L/usr/local/lib -L/usr/lib/perl5/5.38/core_perl/CORE -lperl -lpthread -ldl -lm -lcrypt -lutil -lc -L/usr/lib -ltclstub8.6 -ldl -lz -lpthread -lm

Python version

No response

Neovim diagnostics

No response

Operating System

ArchLinux (up to date)

Declaration

@puremourning
Copy link
Owner

Sample project works?

No sample project for this filetype

This is clearly not true. Can you provide the full contents of 'ranges.cpp' or an example using the example programs?

@Aster89
Copy link
Contributor Author

Aster89 commented Aug 18, 2023

It is irrelevant.

Below is the demo with your struct.cpp unmodified.

If something was luckily fixed about this since when I opened this ticket, I'm sorry, as I'm still using 937ef5b.

asciicast

@puremourning
Copy link
Owner

Thanks, I can repro after watching the video.

As I've said before I much prefer the instructions to be explicit steps that I can read on my phone. Usually I can tell if something is a bug just by reading the instructions, as I have limited time to watch videos.

@puremourning puremourning added bug Something isn't working Severity 2 The plugin or a workflow is inconvenient or occasionally broken labels Aug 18, 2023
@puremourning puremourning changed the title Watchers can't be further expanded after restarting the debugger Can't expand a watch variable after 'restart' command Aug 18, 2023
@mergify mergify bot closed this as completed in #790 Aug 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Severity 2 The plugin or a workflow is inconvenient or occasionally broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants