-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Move to go modules with regret #671
Conversation
I'm incredibly annoyed that go modules are being forced onto us, as the old system with vendor/ and git submodules worked great. Unfortunately, so much FUD around git submodules, even by well-known, highly paid engineers has caused this solution to be deemed most unacceptable. So much for the golang compatibility promise-- turns out it doesn't apply to the useful parts that we actually care about like this. Thanks to frebib for his help with this suffering.
https://github.com/frebib/mgmt/commits/feat/go-mod-fixes |
|
Nice, you rebased on top. Fantastic. Will look later tonight. |
I found that with go modules, gometalinter fails to install, for some reason. You may need this commit to make the tests pass |
Program: program, | ||
Version: version, | ||
Copying: copying, | ||
Flags: flags, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need #670 finished and merged. It would have picked this up!
main.go:52: File is not `goimports`-ed (goimports)
Flags: flags,
diff --git a/main.go b/main.go
index 8eba6fc..8c36be1 100644
--- a/main.go
+++ b/main.go
@@ -49,7 +49,7 @@ func main() {
Program: program,
Version: version,
Copying: copying,
- Flags: flags,
+ Flags: flags,
}
if err := mgmt.CLI(cliArgs); err != nil {
fmt.Println(err)
Replaced by #674 |
I'm incredibly annoyed that go modules are being forced onto us, as the
old system with vendor/ and git submodules worked great. Unfortunately,
so much FUD around git submodules, even by well-known, highly paid
engineers has caused this solution to be deemed most unacceptable.
So much for the golang compatibility promise-- turns out it doesn't
apply to the useful parts that we actually care about like this.
Thanks to frebib for his help with this suffering.
Tips:
please read the style guide before submitting your patch:
docs/style-guide.md
commit message titles must be in the form:
topic: Capitalized message with no trailing period
or:
topic, topic2: Capitalized message with no trailing period
or format a single golang file correctly:
Thanks for contributing to mgmt and welcome to the team!