Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure configs and create configManager #43

Closed
purrplingcat opened this issue Aug 2, 2017 · 3 comments
Closed

Restructure configs and create configManager #43

purrplingcat opened this issue Aug 2, 2017 · 3 comments

Comments

@purrplingcat
Copy link
Owner

purrplingcat commented Aug 2, 2017

Create config manager, who can:

  • Read main config file
  • Read secondary config file or definition
  • Write secondary config file or definition
  • Accessor to main config file context
  • @imports node for declare sub-root nodes to be imported from other files

Config files (included main config file config.json) are placed in ./config

In main file create getter getConfiguration()

Relative dir to main config file config.json is a dir of application! To @import other config file in config must be defined as /config/abc.json

UPDATE: Writing and reading secondary files are obsolete in this issue. This requirement will be resolved in StoreManager.

@purrplingcat
Copy link
Owner Author

purrplingcat commented Aug 7, 2017

In dockerfile create a symlink from ./config.json to ./config/config.json for keep BC. config.example will be placed in ./config.example/config.json

@purrplingcat purrplingcat added this to the 1.3.0 milestone Aug 14, 2017
@purrplingcat
Copy link
Owner Author

Create Pull request after implementing. Do not backport to v1.2.x

@purrplingcat
Copy link
Owner Author

Implemented. But main config file plase is still ./config.json. config files will be moved under issue #74 at later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant