Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Use SocketRocket v0.4 #181

Closed
Stunner opened this issue Jul 17, 2015 · 8 comments
Closed

Update to Use SocketRocket v0.4 #181

Stunner opened this issue Jul 17, 2015 · 8 comments

Comments

@Stunner
Copy link

Stunner commented Jul 17, 2015

SocketRocket has just recently been updated with a new tag: https://github.com/square/SocketRocket/tree/0.4

@lukeredpath
Copy link
Contributor

Thanks, I'll wait to review what has changed first but would be good to move to the new version - good to see some movement on that project at last!

@hamchapman
Copy link
Contributor

Some Pusher users are reporting that app submissions to the app store are being rejected because of SocketRocket using internal API names, as described here: facebookincubator/SocketRocket#226

Updating to 0.4 would include the fix for this issue (as shown in this PR facebookincubator/SocketRocket#252) so if you get a chance to look at this Luke it'd be much appreciated 👍

@brandons
Copy link

After updating to SocketRocket 0.4, it looks like there are still selector names matching those of private APIs. Specifically:

_closeConnection

_openConnection

@hamchapman
Copy link
Contributor

@brandons there is a commit in a fork to rename those two names here: kommen/SocketRocket@db8c681

Are you using cocoapods? If so, you can reference that fork to get the changes in, or you can make you're own fork while waiting for the fixes to be merged into socketrocket's master branch

@brandons
Copy link

@hamchapman Yes. We're using this fork in our project now, but it's certainly not ideal. Cocoapods does not allow you to specify a git repo for a dependency in a Podspec, making this much more messy.

@Stunner
Copy link
Author

Stunner commented Aug 26, 2015

@brandons Interesting, perhaps you can submit an issue for that feature at the CocoaPods repo? 😄

@lukeredpath
Copy link
Contributor

Closed by #185

@lukeredpath
Copy link
Contributor

Please see the new 1.6.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants