Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forceTimeout should be set when disconnecting from reachability event #180

Closed
hamchapman opened this issue Apr 5, 2018 · 1 comment
Closed

forceTimeout should be set when disconnecting from reachability event #180

hamchapman opened this issue Apr 5, 2018 · 1 comment
Labels
enhancement

Comments

@hamchapman
Copy link
Contributor

hamchapman commented Apr 5, 2018 •
edited
Loading

What is the issue?

See title

https://github.com/pusher/pusher-websocket-swift/blob/master/Sources/PusherConnection.swift#L372

should accept a forceTimeout parameter.

This should then call down into self.socket.disconnect() with forceTimeout passed on.

See daltoniam/Starscream#401 (comment)

CC @pusher/mobile
@danielrbrowne
Copy link
Contributor

No longer relevant as this SDK doesn't use Starscream any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielrbrowne @hamchapman