-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request - Update npm package to include latest changes #139
Comments
When will this npm package be upadated? |
plz fix it soon, i am facing same issues. |
React 16 has landed, and the PropTypes issue prevents upgrading to React 16. |
@wehriam is there anything we can do to help get these fixes published? |
For those struggling with the PropTypes warnings, I've added a CI config to my fork of this repo to publish an npm package with the latest changes. This is for my own personal use, and i recommend not using it, but if you really need to fix the propTypes warnings feel free to use my npm package. I'm hoping it'll be a temporary solution for me. |
Please update the npm package so we all can move on with our life. The wait has been long enough for this. |
Well, I just wasted 4 hours tracking down #131 only to discover that the npm package hasn't been updated from 5.1.0 to 5.1.1. Can you just run the command line, update npm, and save us all a lot of headache!? Other than that, great tool and very easy to implement. |
I know it's not an ideal solution, but we got past this by just pointing to the latest commit of this repo. In our package.json, we have react-bootstrap-date-picker set to |
@pushtell Have you seen this? |
Bump. At very least we need min/max date bugfix. |
Bump. It's literally running one line. Maybe something happened to @pushtell ? |
Do we need to fork? |
Yeah unfortunately you'll need to fork it, or use one of the forks that others have made 👍 |
Has anyone tried to put together a fork which aims to supplant the original? Or is everyone just making a bunch of random forks? |
Table of Contents
Expected Behavior
Version of the npm package should be updated from 5.1.0 (current) to 5.1.1
Current Behavior
Currently, version 5.1.0 contains a few bugs, most notably the proptypes warnings that are thrown when the component is used in React 15.
Possible Solution
Updating the npm package to 5.1.1 will include the following bugfixes:
As a further enhancement, the updating of the npm package could be added to the CI build, triggered when version patched. But this is not necessary to address this issue.
Steps to Reproduce (for bugs)
N/A
Context
This component is throwing proptypes warnings in unit tests & development in projects me & my team are working on.
I am also aware that members of the community have had to resort to using their own forks to fix the bugs associated with minDate and maxDate.
Your Environment
N/A
The text was updated successfully, but these errors were encountered: