Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable mapping of read_tmy3 #1517

Closed
AdamRJensen opened this issue Aug 8, 2022 · 1 comment · Fixed by #1623
Closed

Add variable mapping of read_tmy3 #1517

AdamRJensen opened this issue Aug 8, 2022 · 1 comment · Fixed by #1623

Comments

@AdamRJensen
Copy link
Member

Is your feature request related to a problem? Please describe.
This PR proposes that a map_variables parameter be added to the read_tmy3 function. Additionally, the current rename_columns parameter (which removes the units from the column names) should be deprecated. See #714 for a discussion on the topic.

Describe the solution you'd like
A map_variables parameter should be added (defaulting to None), and if specified as True then it should override the rename_columns parameter and map the column names to standard pvlib names. A deperecation warning should be added stating that the rename_columns parameter will be retired starting in pvlib 0.11.0 - the deprecation warning should be silenced if map_variables is specified as either True or False.

@ooprathamm
Copy link
Contributor

#1623 made a pull request for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants