From 3b824640fe3cd3ed7cd788e200c888de16429f20 Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Wed, 9 Mar 2022 14:20:55 -0500 Subject: [PATCH 1/2] better conditional dependency on dataclasses --- setup.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/setup.py b/setup.py index 7301f5eab6..7dc779a16c 100755 --- a/setup.py +++ b/setup.py @@ -43,11 +43,8 @@ 'pytz', 'requests', 'scipy >= 1.2.0', - 'h5py'] - -# include dataclasses as a dependency only on python 3.6 -if sys.version_info.major == 3 and sys.version_info.minor == 6: - INSTALL_REQUIRES.append('dataclasses') + 'h5py', + 'dataclasses; python_version < "3.7"'] TESTS_REQUIRE = ['nose', 'pytest', 'pytest-cov', 'pytest-mock', 'requests-mock', 'pytest-timeout', 'pytest-rerunfailures', From e5b0bb60b1f98eeacb36bbca26b90f479778d8ae Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Wed, 9 Mar 2022 14:45:39 -0500 Subject: [PATCH 2/2] whatsnew --- docs/sphinx/source/whatsnew/v0.9.1.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst index 685a7880a4..c07bd556af 100644 --- a/docs/sphinx/source/whatsnew/v0.9.1.rst +++ b/docs/sphinx/source/whatsnew/v0.9.1.rst @@ -62,6 +62,8 @@ Documentation Requirements ~~~~~~~~~~~~ * numpy >= 1.16.0 is now required for all python versions. (:pull:`1400`) +* Fix an installation issue with ``dataclasses`` on python 3.6 + (:issue:`1302`, :pull:`1422`) Contributors